fix(contracts): Resolve dependency issues and improve cert verifier router deployment workflow#2476
Open
Mc01 wants to merge 2 commits intoLayr-Labs:release/2.6from
Open
fix(contracts): Resolve dependency issues and improve cert verifier router deployment workflow#2476Mc01 wants to merge 2 commits intoLayr-Labs:release/2.6from
Mc01 wants to merge 2 commits intoLayr-Labs:release/2.6from
Conversation
Author
|
Would appreciate feedback if PR should be created against the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fixes configuration issues and improves the cert verifier router deployment scripts encountered when deploying from the v2.6.0 tag.
Changes
Dependency Configuration
m2-mainnetbranch instead ofm2-mainnet-fixesfoundry.lockto track dependency versions explicitlylib/instead ofnode_modules/Deployment Script Improvements
CertVerifierRouterDeployer.s.solfor better readabilityCertVerifierDeployer)Git Ignore & Directory Structure
.gitkeepin output directories (scripts were breaking with directory not exists)Motivation
These changes enable successful deployment of the cert verifier router by resolving dependency mismatches and streamlining the deployment workflow.
Checks
forge test& everything works. Changes do not affect other files than deployment scripts