Skip to content

chore: Remove v1 batcher#2484

Open
litt3 wants to merge 4 commits intomasterfrom
v1-batcher-cleanup
Open

chore: Remove v1 batcher#2484
litt3 wants to merge 4 commits intomasterfrom
v1-batcher-cleanup

Conversation

@litt3
Copy link
Contributor

@litt3 litt3 commented Feb 2, 2026

  • removes V1 batcher

Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3 litt3 self-assigned this Feb 2, 2026
litt3 added 2 commits February 2, 2026 15:45
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.83%. Comparing base (0ba93f1) to head (201c4ac).

Files with missing lines Patch % Lines
disperser/dataapi/metrics_handler.go 0.00% 7 Missing ⚠️
disperser/dataapi/metrics.go 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (9.09%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2484      +/-   ##
==========================================
- Coverage   39.30%   36.83%   -2.48%     
==========================================
  Files         536      520      -16     
  Lines       49005    45446    -3559     
==========================================
- Hits        19261    16739    -2522     
+ Misses      27305    26546     -759     
+ Partials     2439     2161     -278     
Flag Coverage Δ
litt-tests 32.99% <ø> (ø)
unit-tests 37.40% <9.09%> (-2.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@litt3 litt3 marked this pull request as ready for review February 4, 2026 18:41
Comment on lines +75 to +76
DisperserHostname: ctx.GlobalString(flags.DisperserHostnameFlag.Name),
ChurnerHostname: ctx.GlobalString(flags.ChurnerHostnameFlag.Name),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove the disperser/churner configs since they do not have metrics healthchecks in the v2 server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants