feat(ejector): Remove Data API Lookups for V1 protocol#2486
feat(ejector): Remove Data API Lookups for V1 protocol#2486ethenotethan wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes EigenDA v1 protocol signing-rate lookups from the ejector so that it only queries v2 signing rates via the Data API.
Changes:
- Removed v1 signing-rate lookup plumbing from
Ejector(struct fields, constructor args, and evaluation flow). - Updated
mainwiring to pass only the v2 signing-rate lookup. - Removed Data API v1 signing-rate implementation and made v1 requests return an explicit unsupported error.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ejector/main/main.go | Stops passing a duplicated Data API signing-rate lookup; clarifies it’s v2-only. |
| ejector/ejector.go | Removes v1 lookup usage and evaluates validators using only v2 signing rates. |
| ejector/data_api_signing_rate_lookup.go | Deletes v1 lookup implementation and returns an error for v1 protocol requests. |
Comments suppressed due to low confidence (1)
ejector/ejector.go:106
- The inline comment on the
omitPerfectSignersargument still references inconsistent behavior between v1 and v2, but v1 signing-rate lookups have been removed from this code path. Please update the comment to reflect the current (v2-only) behavior so it doesn’t mislead future readers.
ProtocolVersionV2,
true, // omit perfect signers if possible (data API has inconsistent behavior across v1 and v2)
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| switch version { | ||
| case ProtocolVersionV1: | ||
| if !omitPerfectSigners { | ||
| srl.logger.Warn( | ||
| "omitPerfectSigners flag is ignored for ProtocolVersionV1, will never return perfect signers") | ||
| } | ||
| return srl.getV1SigningRates(timeSpan, quorums) | ||
| return nil, fmt.Errorf("eigenda v1 protocol is no longer supported") | ||
| case ProtocolVersionV2: |
There was a problem hiding this comment.
ProtocolVersionV1 now returns an immediate error. Please add a small unit test asserting that v1 requests fail (and return a stable/expected error) so this behavior doesn’t regress silently if code paths are reintroduced later.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2486 +/- ##
==========================================
+ Coverage 39.30% 39.36% +0.05%
==========================================
Files 536 536
Lines 49005 48916 -89
==========================================
- Hits 19261 19255 -6
+ Misses 27305 27219 -86
- Partials 2439 2442 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why are these changes needed?
Nukes V1 data API lookups wrt validator signing rates
Checks