Open
Conversation
Adds the api server for the chainstate indexer
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## indexer-logic #2497 +/- ##
=================================================
+ Coverage 39.02% 39.60% +0.57%
=================================================
Files 557 511 -46
Lines 51655 45941 -5714
=================================================
- Hits 20160 18196 -1964
+ Misses 28950 25587 -3363
+ Partials 2545 2158 -387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+203
to
+220
| // handleListQuorumAPKs returns a list of quorum APK snapshots. | ||
| func (s *Server) handleListQuorumAPKs(c *gin.Context) { | ||
| quorumID := parseUint8Or(c.Query("quorum_id"), 0) | ||
| blockNumber := parseUint64Or(c.Query("block_number"), 0) | ||
| minBlock := parseUint64Or(c.Query("min_block"), 0) | ||
| maxBlock := parseUint64Or(c.Query("max_block"), 0) | ||
|
|
||
| filter := types.QuorumAPKFilter{ | ||
| QuorumID: core.QuorumID(quorumID), | ||
| BlockNumber: blockNumber, | ||
| MinBlock: minBlock, | ||
| MaxBlock: maxBlock, | ||
| } | ||
|
|
||
| apks, err := s.store.ListQuorumAPKs(c.Request.Context(), filter) | ||
| if err != nil { | ||
| s.logger.Error("Failed to list quorum APKs", "error", err) | ||
| c.JSON(http.StatusInternalServerError, gin.H{"error": "failed to list quorum APKs"}) |
Contributor
There was a problem hiding this comment.
is there any reason for using REST over GRPC? iiuc most of backend DA interactions are done over GRPC transport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the api server for the chainstate indexer