Enforce index==0 for empty Keccak Merkle proofs#1622
Open
GarmashAlex wants to merge 1 commit intoLayr-Labs:mainfrom
Open
Enforce index==0 for empty Keccak Merkle proofs#1622GarmashAlex wants to merge 1 commit intoLayr-Labs:mainfrom
GarmashAlex wants to merge 1 commit intoLayr-Labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**Motivation:*e problem you're trying to solve.
In the Keccak implementation, it is worth adding a check require(index == 0, InvalidIndex()) when proof.length == 0, so that the behavior matches the documentation and excludes the case described in OperatorTableUpdater.
Modifications:
Align processInclusionProofKeccak with documentation and SHA-256 behavior by requiring index==0 when proof.length==0.
Result:
This prevents acceptance of arbitrary non-zero indices in single-leaf trees and eliminates a potential bypass in callers that don’t pre-validate indices.