fix: update slasher field immediately when instantEffectBlock=true #1687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses audit finding L-01: Instant slasher setting leaves stale slasher field in storage. When a slasher is set with immediate effect (via createOperatorSets or migrateSlashers), _updateSlasher now also updates the params.slasher field, not just pendingSlasher. This ensures storage consistency where the raw SlasherParams struct reflects the effective slasher immediately. Changes: - AllocationManager._updateSlasher(): Set params.slasher when instantEffectBlock=true - IAllocationManager: Updated NatSpec for SlasherParams struct - AllocationManagerHarness: Added getSlasherParams() for testing raw storage - Unit tests: Added tests verifying storage consistency - Docs: Updated createOperatorSets and migrateSlashers effects 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
ypatil12
force-pushed
the
feat/slashing-improvements-audit-fixes
branch
from
cbb859e to
e4bf888
Compare
ypatil12
merged commit e9bb4b0
into
feat/slashing-improvements-audit-fixes
9 checks passed
ypatil12
added a commit
that referenced
this pull request
Jan 8, 2026
…1687) **Motivation:** Address L-01 finding from the Certora audit: "Instant slasher setting leaves stale slasher field in storage". When `_updateSlasher()` is called with `instantEffectBlock=true`, only `pendingSlasher` and `effectBlock` are updated, leaving the `slasher` field stale (address(0) for new operator sets). While `getSlasher()` returns correct values, raw storage is inconsistent. **Modifications:** - Updated `_updateSlasher()` in `AllocationManager.sol` to set `params.slasher = slasher` when `instantEffectBlock=true` - Updated NatSpec for `SlasherParams` struct in `IAllocationManager.sol` to document storage behavior - Added `getSlasherParams()` helper to `AllocationManagerHarness.sol` for testing raw storage - Added unit tests for instant slasher storage consistency - Updated documentation in `docs/core/AllocationManager.md` **Result:** - Storage is now consistent when creating operator sets or migrating slashers - Both `slasher` and `pendingSlasher` fields are set immediately when `instantEffectBlock=true` - Raw storage reads will return expected values matching `getSlasher()` return value 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Address L-01 finding from the Certora audit: "Instant slasher setting leaves stale slasher field in storage". When
_updateSlasher()is called withinstantEffectBlock=true, onlypendingSlasherandeffectBlockare updated, leaving theslasherfield stale (address(0) for new operator sets). WhilegetSlasher()returns correct values, raw storage is inconsistent.Modifications:
_updateSlasher()inAllocationManager.solto setparams.slasher = slasherwheninstantEffectBlock=trueSlasherParamsstruct inIAllocationManager.solto document storage behaviorgetSlasherParams()helper toAllocationManagerHarness.solfor testing raw storagedocs/core/AllocationManager.mdResult:
slasherandpendingSlasherfields are set immediately wheninstantEffectBlock=truegetSlasher()return value🤖 Generated with Claude Code