Skip to content

fix: assert defaultOperatorSplitBips does not exceed 100% #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xClandestine merged 1 commit into from
Feb 23, 2026
Merged

fix: assert defaultOperatorSplitBips does not exceed 100% #1731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/contracts/core/RewardsCoordinator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ contract RewardsCoordinator is
function _setDefaultOperatorSplit(
uint16 split
) internal {
require(split <= ONE_HUNDRED_IN_BIPS, SplitExceedsMax());
emit DefaultOperatorSplitBipsSet(defaultOperatorSplitBips, split);
defaultOperatorSplitBips = split;
}
Expand Down
11 changes: 10 additions & 1 deletion src/test/unit/RewardsCoordinatorUnit.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,14 +369,23 @@ contract RewardsCoordinatorUnitTests_initializeAndSetters is RewardsCoordinatorU
}

function testFuzz_setDefaultOperatorSplit(uint16 defaultSplitBips) public {
defaultSplitBips = uint16(bound(defaultSplitBips, 0, ONE_HUNDRED_IN_BIPS));
cheats.startPrank(rewardsCoordinator.owner());
uint16 oldDefaultSplitBips = rewardsCoordinator.defaultOperatorSplitBips();
cheats.expectEmit(true, true, true, true, address(rewardsCoordinator));
emit DefaultOperatorSplitBipsSet(rewardsCoordinator.defaultOperatorSplitBips(), defaultSplitBips);
emit DefaultOperatorSplitBipsSet(oldDefaultSplitBips, defaultSplitBips);
rewardsCoordinator.setDefaultOperatorSplit(defaultSplitBips);
assertEq(defaultSplitBips, rewardsCoordinator.defaultOperatorSplitBips(), "defaultOperatorSplitBips not set");
cheats.stopPrank();
}

function testFuzz_setDefaultOperatorSplit_Revert_WhenSplitGreaterThan100(uint16 defaultSplitBips) public {
defaultSplitBips = uint16(bound(defaultSplitBips, ONE_HUNDRED_IN_BIPS + 1, type(uint16).max));
cheats.startPrank(rewardsCoordinator.owner());
cheats.expectRevert(SplitExceedsMax.selector);
rewardsCoordinator.setDefaultOperatorSplit(defaultSplitBips);
}

function testFuzz_setDefaultOperatorSplit_Revert_WhenNotOwner(address caller, uint16 defaultSplitBips)
public
filterFuzzedAddressInputs(caller)
Expand Down
Loading