feat: duration vaults

[eigenmikem]

Motivation:

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications:

Describe the modifications you've done.

Result:

After your change, what will change.

[claude]

Claude encountered an error after 1m 27s —— View job

---

Code Review: Duration Vaults Feature

Reviewing the duration vaults implementation...

Tasks

• Read PR description and documentation
• Review DurationVaultStrategy core logic
• Review storage layout and upgradability
• Review StrategyManager hook integration
• Review StrategyFactory changes
• Check state transitions and edge cases
• Review security considerations
• Assess test coverage
• Provide comprehensive feedback

[claude]

Potential Gas Inefficiency: Loop to check strategy support

This loop iterates through all strategies in the operator set to verify the vault is supported. For large operator sets, this could be gas-intensive.

Suggested optimization:
Consider caching the result after first verification, or use a try-catch approach:

// Option 1: Cache verification
bool private _strategySupportVerified;

function lock() external override onlyVaultAdmin {
    require(depositsOpen(), VaultAlreadyLocked());
    
    if (!_strategySupportVerified) {
        IStrategy[] memory strategies = allocationManager.getStrategiesInOperatorSet(_operatorSet);
        bool supported = false;
        for (uint256 i = 0; i < strategies.length; ++i) {
            if (strategies[i] == IStrategy(address(this))) {
                supported = true;
                break;
            }
        }
        require(supported, StrategyNotSupportedByOperatorSet());
        _strategySupportVerified = true;
    }
    // ... rest of function
}

Alternatively, since _allocateFullMagnitude() will revert if the strategy isn't supported, you could remove this check entirely and rely on that revert, adding a custom error handler.