Skip to content

Conversation

@gpsanant
Copy link
Contributor

The previous logic did not handle the case where there was pending checkpoint on the pod so some validators were proven withdrawn. This would lead to them not being active, which would have them not be counted in the previous regGwei nor in the sumPreviousBeaconBalancesGwei, but they would be in the podBalanceGwei.

This would lead to validators that are proven withdrawn in a pending checkpoint simply not existing in the "previous balance".

In order to avoid this case, we simply calculate the previous balance only on the execution layer by asking the delegation manager for the actively restaked shares and the shares in the withdrawal queue.

@gpsanant gpsanant changed the base branch from master to slashing-magnitudes December 17, 2024 20:52
@jbrower95 jbrower95 self-requested a review December 17, 2024 21:03
@jbrower95 jbrower95 merged commit 6697b27 into slashing-magnitudes Dec 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants