feat: update account requirements in README

[solimander]

No description provided.

[claude]

Claude finished @solimander's task —— View job

---

PR Review: Account Requirements Update

Todo List:

• Read repository CLAUDE.md for context and conventions
• Examine the changes in README.md
• Analyze the specific modifications made
• Provide feedback on code quality, potential issues, and best practices
• Check for any security, performance, or testing considerations

Review Summary

I've completed a comprehensive analysis of this PR, which updates the account requirements section in the README.md file from an allowlist-based system to a billing-based system.

Change Analysis

File: README.md:9

Change: Updated the first prerequisite from:

- **Allowlisted Account** - Required to create apps. Use existing address with `eigenx auth login` or generate with `eigenx auth generate`. Submit an onboarding request [here](https://onboarding.eigencloud.xyz).
+ **Billing Account** - Required to create apps. Use existing address with `eigenx auth login` or generate with `eigenx auth generate`, then set up billing with `eigenx billing subscribe`.

Review Findings

✅ Positive Aspects

1. Clear terminology improvement: "Billing Account" is more descriptive and self-explanatory than "Allowlisted Account"
2. Enhanced user experience: Provides direct CLI command (eigenx billing subscribe) instead of external form submission
3. Streamlined onboarding: Removes dependency on manual approval process
4. Command verification: ✅ Confirmed eigenx billing subscribe command exists in pkg/commands/billing/subscribe.go:13

⚠️ Issues Found & Recommendations

1. Outdated reference remains: The old onboarding link https://onboarding.eigencloud.xyz still exists in pkg/common/contract_caller.go:708 in an error message. This should be updated for consistency.

2. Consider error message alignment: The error message in contract_caller.go mentions reaching deployment limits and directs users to the old onboarding URL, which conflicts with the new billing-based approach.

Code Quality Assessment

• Documentation consistency: ✅ Maintains existing formatting and style
• Clarity: ✅ Significantly improved clarity and actionability
• Command accuracy: ✅ Referenced command is implemented and functional

Security Considerations

• No security risks: Documentation-only change with no security implications
• Auth flow preserved: Maintains proper authentication command references

Performance & Testing

• No performance impact: Documentation change only
• No test changes required: Pure documentation update

Final Assessment

This is a positive change that improves the user onboarding experience by:

• Modernizing from allowlist to self-service billing model
• Providing actionable CLI commands instead of external dependencies
• Maintaining clear, consistent documentation style

Recommendations for Follow-up

1. Consider updating the error message in pkg/common/contract_caller.go:708 to reference the new billing system instead of the old onboarding URL
2. Verify no other references to the old onboarding flow exist in documentation

Overall: ✅ Approved - This change enhances user experience and aligns documentation with the current billing-based system.

---