fix: add --load flag to docker buildx build to enable image pushing #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If the user manually deploys an image with
eigenx app deployand it doesn't have EigenX components, the CLI adds them, if the user replies Yes toWould you like to layer the image with EigenX components?. However, the CLI fails to push the new image it creates.Modifications:
Added the missing
--loadflag to docker buildx. This flag tells Docker buildx to load the built image into the local Docker daemon, making it available for the subsequent docker push operation. Without this flag, buildx only stores the image in the build cache and doesn't make it available for pushing.Result:
Users can successfully deploy a pre-built image that doesn't have the EigenX components.
Testing:
Previously,
eigenx app deploy dhvanipa/mc-server:1.21.10would fail with2025/11/11 09:47:38 failed to ensure image compatibility: failed to layer published image: failed to push layered image: build error: tag does not exist: dhvanipa/mc-server:1.21.10-eigenxOpen questions:
N/A