Skip to content

V3.0.5: Add -u and -E options #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeChatP merged 34 commits into from
Feb 18, 2025

doc: update Docs and default config

31f3ef1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

V3.0.5: Add -u and -E options #65

doc: update Docs and default config
31f3ef1
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Feb 18, 2025 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.84.1 (e71f9a9a9 2025-01-27)
  • cargo 1.84.1 (66221abde 2024-11-19)
  • clippy 0.1.84 (e71f9a9a98 2025-01-27)

Annotations

Check warning on line 501 in rar-common/src/database/options.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` is redundant 

warning: this `map_or` is redundant
   --> rar-common/src/database/options.rs:501:9
    |
501 |         self.as_ref().map_or(false, |set| set.env_matches(needle))
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_some_and instead: `self.as_ref().is_some_and(|set| set.env_matches(needle))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or

Check warning on line 547 in rar-common/src/database/finder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` is redundant 

warning: this `map_or` is redundant
   --> rar-common/src/database/finder.rs:547:5
    |
547 |     (*actortype).fetch_id().map_or(false, |id| id == 0)
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `((*actortype).fetch_id() == Some(0))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or

Check warning on line 543 in rar-common/src/database/finder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` is redundant 

warning: this `map_or` is redundant
   --> rar-common/src/database/finder.rs:543:5
    |
543 |     (*actortype).fetch_id().map_or(false, |id| id == 0)
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `((*actortype).fetch_id() == Some(0))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
    = note: `#[warn(clippy::unnecessary_map_or)]` on by default

Check warning on line 122 in rar-common/src/database/actor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de 

warning: the following explicit lifetimes could be elided: 'de
   --> rar-common/src/database/actor.rs:122:14
    |
122 |         impl<'de> Visitor<'de> for IdVisitor {
    |              ^^^          ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
122 -         impl<'de> Visitor<'de> for IdVisitor {
122 +         impl Visitor<'_> for IdVisitor {
    |
View more details on GitHub Actions