Conversation
This huge commit is rewriting the optimisation, securing everything and simplifying.
This should further enhance the performance.
…ck the best graph.
…odules for performance
…n for performance
…dule - Refactored the serialization logic for SConfig, SRole, SSetuidSet, SSetgidSet, SCredentials, STask, and SCommands to fix inconsistencies. - Added tests for serialization of SConfig, SRole, SSetuidSet, SSetgidSet, SCredentials, STask, and SCommands to ensure correctness. - Enhanced handling of human-readable and binary serialization formats.
- Added conversion rules to the CLI parser in `pair.rs` to handle conversion actions. - Introduced a new module `convert.rs` to encapsulate the conversion logic, including writing configuration files in different formats (JSON, CBOR). - Refactored `process_input` in `process.rs` to handle conversion inputs and streamline the handling of storage configurations. - Updated the main function in `main.rs` to work with the new settings structure and removed unnecessary storage method checks. - Cleaned up unused error handling in `finder/mod.rs` related to unsupported storage methods.
- Updated the `SPathOptions` to `DPathOptions` in various deserializer implementations for better clarity and functionality. - Introduced a new method `default_path` in `DPathOptions` to encapsulate default path initialization logic. - Enhanced the `union` method in `DPathOptions` to manage path options merging more effectively. - Simplified the `user_matches` method in `ActorsFinderDeserializer` by removing unnecessary `if let` constructs. - Added unit tests for timezone safety checks and path handling.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #70 +/- ##
======================================
Coverage ? 74.05%
======================================
Files ? 33
Lines ? 4108
Branches ? 0
======================================
Hits ? 3042
Misses ? 1066
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
There are many things to optimize. I think we are quite acceptable now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should optimize RootAsRole project