-
-
Notifications
You must be signed in to change notification settings - Fork 30
v4 #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6782a2d to
5373696
Compare
37c0bf8 to
ac8ee8f
Compare
|
Just published v4 beta version you can install it by running npm install --save-dev typescript-transform-paths@betaping @lppedd @nonara @denis-sokolov @blimmer @anthony-y-zhu14 @spdaley in case you want to try the beta before marking it as stable. I'll leave it in beta for a while to get some feedback. Otherwise I'll publish the v4 version after a while if everything looks good. |
|
Thanks, I'll give the Nx plugin a go tomorrow. |
|
Hey @danielpza. Looks pretty good here. Nice work! The only major thing I would suggest is to not drop the TS "harmony factory". I definitely agree that doing a new major now gives us the opportunity to drop the older TS versions. Overall, periodic pruning on major releases is a good strategy and is necessary IMO. With that said, given historical patterns, we will likely find ourselves facing semi-frequent changes to TS compiler API, even on non-major versions, as they don't follow semver (albeit for good reasons). As I recall, we also had to do some special work in replicating some internal TS API functionality due to elision, which meant even non-public API changes could cause breaking changes. (Although, if memory serves, Ron Buckton may have tightened that a bit so that may be no longer necessary) In any case, the harmony factory is fairly easy to maintain and allows us to easily add new branches rather than have to release a new major version whenever TS API changes. Happy to discuss more or provide more context if you'd like. Other than that, everything looks good! 🎉 |
yes. We need to consider doing this more often, perhaps even during minor releases as well, and just keep a compatibility table updated.
I'm not fully against the harmony factory, personally I don't have a reason to add it back at this point, but I won't be against it if we need it. |
|
@danielpza For clarity, if we don't, we will have to have to do a new major version every time the TS compiler API changes (or sometimes non-public internals), and we would need to drop support for all prior TS versions each time. Often this is even from a minor update, where a single parameter is added to one of the functions. Pre-harmony factory, this was tedious. Once it was perfected, it was trivial to handle routing these differences and it was very simple to split for new changes. |
Highlights:
This is maintenance release for the most part. No new feature or import resolution changes.
Migration docs
Wishlist
(some of these might get released in the current version):Remove external plugins integrations (nx plugin, etc) to keep surface area small and make maintenance easier, bring nx plugin back, the entry point is small enough to keep and it seems most folks using this plugin are because of nx Why and how are you using this project? #438add support for latest typescript version (5.9.2)can be done post v4TODO
closes #145