Use datetime.now(datetime.UTC) instead of datetime.utcnow()#832
Merged
Use datetime.now(datetime.UTC) instead of datetime.utcnow()#832
Conversation
LeMyst
force-pushed
the
replace-utcnow
branch
from
662cc1d to
51060d6
Compare
LeMyst
force-pushed
the
replace-utcnow
branch
from
51060d6 to
6f41cb0
Compare
LeMyst
force-pushed
the
replace-utcnow
branch
from
6f41cb0 to
2b6b898
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates deprecated datetime.utcnow() calls to use the modern datetime.now(datetime.timezone.utc) approach. The utcnow() method has been deprecated in Python 3.12+ in favor of timezone-aware alternatives.
- Replaces
datetime.utcnow()withdatetime.now(datetime.timezone.utc)in logging statements - Updates time value generation in the Time datatype to use the modern datetime approach
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
wikibaseintegrator/wbi_helpers.py |
Updates two logging statements in rate limiting and maxlag error handling to use modern UTC datetime |
wikibaseintegrator/datatypes/time.py |
Updates "now" time value generation to use timezone-aware UTC datetime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.