Do not rely on global L

[m1gu3l]

Should fix #874

[m1gu3l]

This injects L to each file and assigns it import "leaflet"

[m1gu3l]

This tells UMD wrapper to resolve leaflet with global L

[pke]

Wicked! ;) I have no time to test it right now, but I will eventually. Interesting to see what @IvanSanchez has to say to it.

The whole leaflet ecosystem needs a serious ES6 overhaul with a major new release.

[ivansieder]

@IvanSanchez is there any way to get your review on this? That'd be awesome!

[frafra]

I am sorry for bumping this, but is there any news?

[jacobweber]

Any way to get this merged? Thanks.

[frafra]

@ykzeng sorry to bother you, but could you please provide feedback on this PR?

[Schleuse]

Works great for me 👍

[JayceeZ]

Using this change in our fork since ages.

[jonkoops]

@mourner could you make me a collaborator so I can review PRs on this repo?

[ykzeng]

@mourner could you make me a collaborator so I can review PRs on this repo?

@jonkoops still interested in this? I would be happy to check if I can add you

[ykzeng]

Hi @IvanSanchez could you kindly help review this to make sure this is compliant with the plugin guideline? Would love to merge this or hear from you otherwise, I can certainly help if any other update will be needed as you might suggest.

[jonkoops]

I am currently too busy with work on core Leaflet, so I will not have time to review this work anytime soon. I do intend to refactor most if not all of the official Leaflet plugins once we have a solid idea of what the API surface for Leaflet 2.0 will be.

[ykzeng]

np @jonkoops let's stay in touch if you need any help hand

[chintal]

@m1gu3l Thank you for your PR. After over a day of pulling my hair out trying to figure out why clustering was so broken between remix, react-leaflet-cluster, and leaflet.markercluster, your solution worked perfectly on the first try.

I was able to use it by :

• manually apply your changes to a fresh fork of the latest main, (build/rollupconfig.js)
• force installing @rollup/plugin-inject
• building the js
• publishing the whole package including the built js back to github and installing from there instead

Here's hoping the issue can be resolved in the package itself, at which point I can switch back and nuke the fork.

[MariaAbadi]

@IvanSanchez @jonkoops it's a small PR and could fix some uncanny issues with the plugin. Please find 15 minutes to review it.

[sodonnel]

Thank you for this. For anyone who comes behind me, I forked the repo, added this repo as a remote and pulled this GH PR branch.

Then using docker I built the code:

docker run -it -v "$PWD":/usr/src/app -w /usr/src/app --name nodebuild2 node:22 /bin/sh
# npm install jake
# npm install --legacy-peer-deps

> leaflet.markercluster@1.4.1 prepublish
> jake

	Check passed.

Rolled up.
Uglyfied.

up to date, audited 608 packages in 5s

73 vulnerabilities (4 low, 18 moderate, 30 high, 21 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

From there the dist folder was created and the new js file seems to work in my initial test with a Rails Stimulus controller.