Fix CMake CMP0174 warnings and bump miniz to v3.1.0 #375

Copilot · 2026-01-05T16:16:37Z

Addresses feedback from PR #374 to fix CMake configuration warnings and update the miniz library.

Changes

Fixed CMP0174 warnings: Removed empty CONFIGURE_COMMAND "" and BUILD_COMMAND "" parameters from all FetchContent_Declare calls for xxhash, zstd, libdeflate, fmt, and fmtlog dependencies. These empty parameters triggered policy warnings in CMake 3.31.
Updated miniz dependency: Bumped from v3.0.2 (d9d197c9...) to v3.1.0 (174573d6...). The newer version includes cmake_minimum_required(VERSION 3.5...3.12) which provides proper CMake support.
Rebased on latest master: All changes are now based on the latest master branch.

This resolves all CMP0174 policy warnings when configuring the project with CMake 3.31, while maintaining compatibility with the existing build system. The miniz library continues to use the add_subdirectory approach which works correctly with the updated version.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

moonshadow565 · 2026-01-05T16:36:07Z

@copilot Also fix:

CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):
  The BUILD_COMMAND keyword was followed by an empty string or no value at
  all.  Policy CMP0174 is not set, so cmake_parse_arguments() will unset the
  ARG_BUILD_COMMAND variable rather than setting it to an empty string.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978:EVAL:1 (__FetchContent_Populate)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978 (cmake_language)
  cslol-tools/dep/CMakeLists.txt:16 (FetchContent_Populate)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):
  The CONFIGURE_COMMAND keyword was followed by an empty string or no value
  at all.  Policy CMP0174 is not set, so cmake_parse_arguments() will unset
  the ARG_CONFIGURE_COMMAND variable rather than setting it to an empty
  string.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978:EVAL:1 (__FetchContent_Populate)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978 (cmake_language)
  cslol-tools/dep/CMakeLists.txt:16 (FetchContent_Populate)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):
  The BUILD_COMMAND keyword was followed by an empty string or no value at
  all.  Policy CMP0174 is not set, so cmake_parse_arguments() will unset the
  ARG_BUILD_COMMAND variable rather than setting it to an empty string.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978:EVAL:1 (__FetchContent_Populate)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978 (cmake_language)
  cslol-tools/dep/CMakeLists.txt:33 (FetchContent_Populate)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):
  The CONFIGURE_COMMAND keyword was followed by an empty string or no value
  at all.  Policy CMP0174 is not set, so cmake_parse_arguments() will unset
  the ARG_CONFIGURE_COMMAND variable rather than setting it to an empty
  string.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978:EVAL:1 (__FetchContent_Populate)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978 (cmake_language)
  cslol-tools/dep/CMakeLists.txt:33 (FetchContent_Populate)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):
  The BUILD_COMMAND keyword was followed by an empty string or no value at
  all.  Policy CMP0174 is not set, so cmake_parse_arguments() will unset the
  ARG_BUILD_COMMAND variable rather than setting it to an empty string.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978:EVAL:1 (__FetchContent_Populate)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978 (cmake_language)
  cslol-tools/dep/CMakeLists.txt:59 (FetchContent_Populate)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):
  The CONFIGURE_COMMAND keyword was followed by an empty string or no value
  at all.  Policy CMP0174 is not set, so cmake_parse_arguments() will unset
  the ARG_CONFIGURE_COMMAND variable rather than setting it to an empty
  string.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978:EVAL:1 (__FetchContent_Populate)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978 (cmake_language)
  cslol-tools/dep/CMakeLists.txt:59 (FetchContent_Populate)
This warning is for project developers.  Use -Wno-dev to suppress it.
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed
-- Performing Test COMPILER_HAS_DEPRECATED
-- Performing Test COMPILER_HAS_DEPRECATED - Success
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):
  The BUILD_COMMAND keyword was followed by an empty string or no value at
  all.  Policy CMP0174 is not set, so cmake_parse_arguments() will unset the
  ARG_BUILD_COMMAND variable rather than setting it to an empty string.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978:EVAL:1 (__FetchContent_Populate)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978 (cmake_language)
  cslol-tools/dep/CMakeLists.txt:93 (FetchContent_Populate)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):
  The CONFIGURE_COMMAND keyword was followed by an empty string or no value
  at all.  Policy CMP0174 is not set, so cmake_parse_arguments() will unset
  the ARG_CONFIGURE_COMMAND variable rather than setting it to an empty
  string.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978:EVAL:1 (__FetchContent_Populate)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978 (cmake_language)
  cslol-tools/dep/CMakeLists.txt:93 (FetchContent_Populate)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):
  The BUILD_COMMAND keyword was followed by an empty string or no value at
  all.  Policy CMP0174 is not set, so cmake_parse_arguments() will unset the
  ARG_BUILD_COMMAND variable rather than setting it to an empty string.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978:EVAL:1 (__FetchContent_Populate)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978 (cmake_language)
  cslol-tools/dep/CMakeLists.txt:109 (FetchContent_Populate)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):
  The CONFIGURE_COMMAND keyword was followed by an empty string or no value
  at all.  Policy CMP0174 is not set, so cmake_parse_arguments() will unset
  the ARG_CONFIGURE_COMMAND variable rather than setting it to an empty
  string.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978:EVAL:1 (__FetchContent_Populate)
  C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1978 (cmake_language)
  cslol-tools/dep/CMakeLists.txt:109 (FetchContent_Populate)
This warning is for project developers.  Use -Wno-dev to suppress it.
```
Also rebase on latest master.

Copilot · 2026-01-05T16:45:08Z

@copilot Also fix:

CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.31/Modules/FetchContent.cmake:1564 (cmake_parse_arguments):

...

Fixed CMP0174 warnings by removing empty CONFIGURE_COMMAND and BUILD_COMMAND parameters from all FetchContent_Declare calls (commit 11b1cf8). Also rebased on latest master.

Co-authored-by: moonshadow565 <7480230+moonshadow565@users.noreply.github.com>

…MMAND Co-authored-by: moonshadow565 <7480230+moonshadow565@users.noreply.github.com>

Copilot AI assigned Copilot and moonshadow565 Jan 5, 2026

Copilot AI mentioned this pull request Jan 5, 2026

feat: introduce local patcher dll to cmake #374

Merged

Copilot started work on behalf of moonshadow565 January 5, 2026 16:17 View session

Base automatically changed from update-cslol to master January 5, 2026 16:19

Copilot AI changed the title ~~[WIP] Add improvements based on feedback for local patcher DLL implementation~~ Bump miniz to v3.1.0 to resolve CMake version requirements Jan 5, 2026

Copilot AI requested a review from moonshadow565 January 5, 2026 16:22

Copilot finished work on behalf of moonshadow565 January 5, 2026 16:22

Copilot started work on behalf of moonshadow565 January 5, 2026 16:36 View session

moonshadow565 marked this pull request as ready for review January 5, 2026 16:45

Copilot AI changed the title ~~Bump miniz to v3.1.0 to resolve CMake version requirements~~ Fix CMake CMP0174 warnings and bump miniz to v3.1.0 Jan 5, 2026

Copilot finished work on behalf of moonshadow565 January 5, 2026 16:47

Copilot AI and others added 2 commits January 5, 2026 17:48

Bump miniz dependency from v3.0.2 to v3.1.0

31d4e24

Co-authored-by: moonshadow565 <7480230+moonshadow565@users.noreply.github.com>

Fix CMP0174 warnings by removing empty CONFIGURE_COMMAND and BUILD_CO…

841e44f

…MMAND Co-authored-by: moonshadow565 <7480230+moonshadow565@users.noreply.github.com>

moonshadow565 force-pushed the copilot/sub-pr-374 branch from 11b1cf8 to 841e44f Compare January 5, 2026 16:48

moonshadow565 merged commit 36c9e86 into master Jan 5, 2026
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CMake CMP0174 warnings and bump miniz to v3.1.0 #375

Fix CMake CMP0174 warnings and bump miniz to v3.1.0 #375

Uh oh!

Copilot AI commented Jan 5, 2026 •

edited

Loading

Uh oh!

moonshadow565 commented Jan 5, 2026

Uh oh!

Copilot AI commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix CMake CMP0174 warnings and bump miniz to v3.1.0 #375

Fix CMake CMP0174 warnings and bump miniz to v3.1.0 #375

Uh oh!

Conversation

Copilot AI commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

moonshadow565 commented Jan 5, 2026

Uh oh!

Copilot AI commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 5, 2026 •

edited

Loading