Skip to content

refactor(ltk_ritobin): rewrite API#112

Open
Crauzer wants to merge 135 commits intomainfrom
alan/ritobin-rewrite
Open

refactor(ltk_ritobin): rewrite API#112
Crauzer wants to merge 135 commits intomainfrom
alan/ritobin-rewrite

Conversation

@Crauzer
Copy link
Member

@Crauzer Crauzer commented Mar 5, 2026

No description provided.

@Crauzer Crauzer requested a review from alanpq March 5, 2026 15:51
@Crauzer Crauzer added crate:ltk_ritobin Ritobin text format crate priority:high High priority labels Mar 5, 2026
@Crauzer Crauzer added the format:bin BIN property format label Mar 5, 2026
@alanpq
Copy link
Contributor

alanpq commented Mar 5, 2026

still needs a fair bit of work to be feature complete afaik

@alanpq alanpq force-pushed the alan/ritobin-rewrite branch from dc44cfd to a913f18 Compare March 5, 2026 19:32
@alanpq alanpq force-pushed the alan/ritobin-rewrite branch 2 times, most recently from febfd09 to 65d9256 Compare March 5, 2026 20:40
@alanpq alanpq force-pushed the alan/ritobin-rewrite branch 2 times, most recently from e401791 to 8b83e0f Compare March 5, 2026 20:50
@alanpq alanpq force-pushed the alan/ritobin-rewrite branch 2 times, most recently from 88a46e8 to 244ec65 Compare March 6, 2026 20:01
@alanpq alanpq force-pushed the alan/ritobin-rewrite branch 2 times, most recently from 1118460 to e8f6187 Compare March 6, 2026 20:41
alanpq added 4 commits March 18, 2026 21:00
@alanpq
feat: print fixed tokens regardless of span
68a3dcc 
stuff like punctuation doesn't need to have a valid span to know what
should be printed. this makes it cheaper to build arbitrary cst's
without needing to allocate string space for known grammar symbols
@alanpq
fix: print token kind in Cst::print helper
6cafe21
@alanpq
wip: cst construction from bin tree
c747950
@alanpq
wip: round trip tests
8d6b970
@alanpq alanpq force-pushed the alan/ritobin-rewrite branch from e50c853 to 8d6b970 Compare March 18, 2026 21:00
@alanpq alanpq force-pushed the alan/ritobin-rewrite branch from 00e2e85 to 07cdf1d Compare March 19, 2026 18:16
alanpq added 20 commits March 19, 2026 18:19
@alanpq
fix: don't include quotes when building strings for bin
2e83328
@alanpq
feat (typecheck): build mat44
36a7af8
@alanpq
feat: impl serde traits for cst stuff
3ca1ba9
@alanpq
feat: impl Span::is_empty
87f7ff2
@alanpq
feat: fix list item stuff + more cst builder tests
17c32c2
@alanpq
fix: remove bars in Cst::print
009a0b9
@alanpq
fix: bring back some tests
3e76572
@alanpq
feat (typecheck): inject into Optionals
5fe3b7f
@alanpq
fix: cst builder public api
b421fcf
@alanpq
fix: support more types in cst builder
dda1410
@alanpq
fix: print impl
d20930d
@alanpq
fix (typecheck): coerce values when resolving entries
f941190
@alanpq
fix: coerce value types in lists
97c7641
@alanpq
fix: cst builder struct/embedded building + other hash printing
4fd9b9e
@alanpq
feat (print): only break nested lists if the parent list has >1 item
febdfff
@alanpq
fix (print): increase default line width -> 120
086358a
@alanpq
fix: coerce map key values to the map key type
978445d
@alanpq
fix: entry value coercion
2477968
@alanpq
feat (typecheck): coerce to ObjectLink/WadChunkLink
0d893ba
@alanpq
test: nicer assertion messages in roundtrip test
ac72886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanpq alanpq Awaiting requested review from alanpq

At least 1 approving review is required to merge this pull request.

Assignees

@alanpq alanpq

@Crauzer Crauzer

Labels

crate:ltk_ritobin Ritobin text format crate format:bin BIN property format priority:high High priority

Projects

league-toolkit
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Crauzer @alanpq