Conversation
alanpq
force-pushed
the
alan/feat/public-api
branch
2 times, most recently
from
46c7699 to
c08e0de
Compare
Member
|
Is this ready ? |
Contributor
Author
I'd say not quite yet |
alanpq
force-pushed
the
alan/feat/public-api
branch
from
4a0a7bc to
f058055
Compare
this is a breaking change for the public api of IndexBuffer, since it uses generics for the format instead of a runtime enum
alanpq
force-pushed
the
alan/feat/public-api
branch
from
f058055 to
0a71914
Compare
Crauzer
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on changes from #28 (merge that first)
Breaking Public API changes:
IndexBuffernow has uses a generic for the format, instead of an enum (IndexBuffer<u16>, etc)IndexBuffer::buffer&VertexBuffer::bufferrenamed toas_bytesvertex_buffer/index_buffermodules insidememtovertex/indexmemmodule no longer re-exportsvertex::*, only a few specific onesAABB::new->AABB::from_cornersAABB::from_vertex_iter->AABB::of_pointsNew Features / QOL
IndexBuffer::read(reader: R, count: usize) -> SelfVertexBuffer::into_inner(self) -> Vec<u8>