Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the workshop module by adding bulk operations for packing and deleting multiple projects simultaneously. It replaces the bottom selection bar with a more accessible actions menu in the toolbar, and adds session-based persistence for selections to preserve state across page refreshes.
Changes:
- Added bulk pack and bulk delete dialogs with progress tracking and cancellation support
- Replaced SelectionActionBar with ActionsMenu in toolbar for better UX
- Added session storage persistence for workshop project selections using custom Set/Map serialization
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/stores/workshopSelection.ts | Added persist middleware with session storage for selection state |
| src/stores/workshopDialogs.ts | Added state management for bulk pack and delete dialog projects |
| src/stores/storage.ts | New custom JSON storage with Set/Map serialization support |
| src/routes/workshop/index.tsx | Integrated bulk dialogs, removed SelectionActionBar |
| src/modules/workshop/components/index.ts | Updated exports for new bulk dialogs, removed SelectionActionBar |
| src/modules/workshop/components/WorkshopToolbar.tsx | Added ActionsMenu next to select all button |
| src/modules/workshop/components/SelectionActionBar.tsx | Removed bottom action bar component |
| src/modules/workshop/components/ProjectCard.tsx | Enhanced styling with opacity for disabled state and improved test button logic |
| src/modules/workshop/components/BulkPackDialog.tsx | New dialog for bulk packing with format selection and progress tracking |
| src/modules/workshop/components/BulkDeleteDialog.tsx | New dialog for bulk deletion with confirmation and progress tracking |
| src/modules/workshop/components/ActionsMenu.tsx | New dropdown menu for bulk actions (delete, pack, test, clear) |
| src/components/Checkbox.tsx | Added cursor-pointer class for better UX |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.