Optimize InputFilter

[LeanderCS]

Summary by Bito

This pull request introduces significant enhancements to the InputFilter component, focusing on performance optimizations, improved type hinting, and refined input validation logic. Key changes include method refactoring for clarity, updates to Docker configurations, and documentation improvements, all aimed at streamlining the development process and enhancing user experience.

[Copilot]

Pull Request Overview

This PR modernizes and streamlines InputFilter by adopting native Python 3.9+ type hints, centralizing date parsing, simplifying validator implementations, and improving JSON‐input handling.

• Refactored all List[...]/Dict[...] to built-in list[...]/dict[...] hints across code and stubs
• Introduced a shared parse_date helper and simplified date validators
• Enhanced request decorator to default non-dict JSON to {} and added tests for diverse JSON payloads

Reviewed Changes

Copilot reviewed 86 out of 86 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/test_input_filter.py	Added tests for non-dict JSON, invalid JSON, mixed types, and required/fallback scenarios
pyproject.toml	Bumped package version from 0.5.4 to 0.5.5
flask_inputfilter/input_filter.py	Refactored type hints, optimized validate logic, added interned‐strings map
flask_inputfilter/helpers/parse_date.py	New helper function to unify ISO‐8601/date/datetime parsing in validators
flask_inputfilter/validators/*	Updated typing, removed redundant parse methods, defaulted error messages in XOR/OR validators
flask_inputfilter/filters/*	Added __slots__ = () for memory optimization in stateless filters
env_configs/*.Dockerfile	Adjusted COPY .. /app ordering to reduce early rebuilds
docker-compose.yaml	Reorganized service names and build contexts
docs/source/*	Updated documentation to use dict[str, Any] hints and reflect generator changes

Comments suppressed due to low confidence (5)

flask_inputfilter/input_filter.py:132

• The 405 response now omits a message body; consider restoring a descriptive payload (e.g., 'Method Not Allowed') or using Flask's abort for better client feedback.

                    return Response(status=405)

flask_inputfilter/input_filter.py:156

• Validation errors now only return HTTP 400 without JSON error details. To maintain the original API, include the error JSON (e.args[0]) in the response body.

                    )

tests/test_input_filter.py:1120

• [nitpick] The docstring for test_copy is ambiguous and no longer matches the original deep‐copy intention. Update it to clearly describe what the test actually verifies.

        """Test that copy copies the value of the field to the current

flask_inputfilter/input_filter.py:20

• [nitpick] The _INTERNED_STRINGS constant is defined but never used; removing it will simplify the code and reduce unnecessary memory allocation.

_INTERNED_STRINGS = {

env_configs/pure.Dockerfile:16

• [nitpick] Duplicating COPY .. /app after installing scripts can invalidate Docker cache. Move source copy before dependency steps or remove the redundant instruction to optimize build caching.

COPY .. /app

[sonarqubecloud]

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[bito-code-review]

Bito Review Skipped - No Changes Detected

Bito didn't review this pull request because we did not detect any changes in the pull request to review.