Skip to content

[REFACTOR] Preparation work related to LRN-49750 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
roger-marley-lrn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[REFACTOR] Preparation work related to LRN-49750 #100

roger-marley-lrn wants to merge 2 commits into from
+3 −7

Conversation

@roger-marley-lrn
Copy link

@roger-marley-lrn roger-marley-lrn commented Jan 28, 2026 •
edited
Loading

Overview

  • Bumping PHP supported versions to those currently within "Security Support" term
  • Removing deprecated call that is causing deprecation notices in LP
  • Preparatory for later PHP upgrade related work, since this is a dependency of LP

Checklist

  • Feature

  • Bug

  • ChangeLog.md updated

  • Tests added

  • All testsuite passes

  • make dist completed successfully

@roger-marley-lrn roger-marley-lrn changed the title [REFACTOR] curl_close() removed - it's a no-op since PHP 8.0 [REFACTOR] Preparation work related to LRN-49750 Jan 28, 2026
@roger-marley-lrn roger-marley-lrn marked this pull request as draft January 28, 2026 04:24
@roger-marley-lrn roger-marley-lrn marked this pull request as ready for review January 28, 2026 04:28
@roger-marley-lrn
Copy link
Author

roger-marley-lrn commented Jan 28, 2026 •
edited by atlassian bot
Loading

hi @danny-beton-lrn, a minor one, but could I get this one merged and released as v1.2.1?
LP's has a dependency on this, and I'm doing some preparatory cleanup for LRN-49750

@roger-marley-lrn
Copy link
Author

roger-marley-lrn commented Jan 28, 2026

(@danny-beton-lrn also I believe the ChangeLog.md needs updating, and wasn't in the v1.2.0 release - so I'll let you work out what's to go there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danny-beton-lrn danny-beton-lrn Awaiting requested review from danny-beton-lrn

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roger-marley-lrn