Skip to content

Nbgl on nano fixes#328

Merged
iartemov-ledger merged 4 commits intodevelopfrom
nbgl-on-nano_fixes
Jun 2, 2025
Merged

Nbgl on nano fixes#328
iartemov-ledger merged 4 commits intodevelopfrom
nbgl-on-nano_fixes

Conversation

@iartemov-ledger
Copy link
Contributor

@iartemov-ledger iartemov-ledger commented May 23, 2025

Addressing https://ledgerhq.atlassian.net/browse/B2CA-2132?focusedCommentId=553816 namely:

  • icons redesign follow-up (Home scree: white background and the same as on Dash Board; Operation: black screen/inversed)
  • More detailed "Loading transaction" and "Loading message" instead of generic "Processing"
  • Using SDK-provided app_exit()
  • Fixing the return to Home menu forgotten in Nbgl migration for Nano devices #325
  • On transaction using LL Nano screen freeze for some time until finally the "Processing" appears (https://ledgerhq.atlassian.net/browse/B2CA-2132?focusedCommentId=553816)=> it appears to exists before the NBGL migration - let's consider it separately
  • Messages indexes restart on each chunk using nbgl_useCaseReviewStreamingContinue() => we should fix it probably by removing chunking and streaming, as separate change-set

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (f644b21) to head (9d72e39).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #328   +/-   ##
========================================
  Coverage    84.69%   84.69%           
========================================
  Files           17       17           
  Lines         2228     2228           
========================================
  Hits          1887     1887           
  Misses         341      341           
Flag Coverage Δ
unittests 84.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iartemov-ledger iartemov-ledger force-pushed the nbgl-on-nano_fixes branch 4 times, most recently from 210b6a0 to ebf5e44 Compare May 28, 2025 14:45
@iartemov-ledger iartemov-ledger marked this pull request as ready for review June 2, 2025 12:51
@iartemov-ledger iartemov-ledger requested a review from bigspider June 2, 2025 12:51
bigspider
bigspider previously approved these changes Jun 2, 2025
Copy link
Collaborator

@bigspider bigspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor comments

@iartemov-ledger iartemov-ledger merged commit de2c15d into develop Jun 2, 2025
189 checks passed
@iartemov-ledger iartemov-ledger deleted the nbgl-on-nano_fixes branch June 2, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants