Security Review 1.19.0

.github/workflows/build_and_functional_tests.yml

@@ -61,3 +61,21 @@ jobs:
       additional_app_binaries_artifact_dir: ./tests/ragger/.test_dependencies/clone/build/
       test_options: "--setup lib_mode"
       regenerate_snapshots: ${{ inputs.golden_run == 'Open a PR' }}
+
+  build_mem_app:
+    name: Build Memory application using the reusable workflow
+    uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@v1
+    with:
+      upload_app_binaries_artifact: "memory_elfs"
+      flags: "memory_profiling"
+      run_for_devices: '["nanox"]'
+
+  ragger_mem_tests:
+    name: Run Memory tests using the reusable workflow
+    needs: build_application
+    uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_ragger_tests.yml@v1
+    with:
+      download_app_binaries_artifact: "memory_elfs"
+      test_options: " -s 2>&1 | tools/valground.py -q"
+      run_for_devices: '["nanox"]'
+      upload_snapshots_on_failure: false

CHANGELOG.md

@@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.19.0](../../compare/1.18.1...1.19.0) - 2025-xx-xx
+
 ## [1.18.1](../../compare/1.18.0...1.18.1) - 2025-08-27
 
 ### Fixed

Makefile

@@ -36,23 +36,23 @@ endif
 include ./makefile_conf/chain/$(CHAIN).mk
 
 APPVERSION_M = 1
-APPVERSION_N = 18
-APPVERSION_P = 1
-APPVERSION = $(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)
+APPVERSION_N = 19
+APPVERSION_P = 0
+APPVERSION = $(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)-dev
 
 # Application source files
 APP_SOURCE_PATH += src src_features src_plugins src_nbgl
 APP_SOURCE_FILES += $(filter-out ./ethereum-plugin-sdk/src/main.c, $(wildcard ./ethereum-plugin-sdk/src/*.c))
 INCLUDES_PATH += ./ethereum-plugin-sdk/src
 
-ifeq ($(TARGET_NAME),$(filter $(TARGET_NAME),TARGET_STAX TARGET_FLEX))
-NETWORK_ICONS_FILE = $(GEN_SRC_DIR)/net_icons.gen.c
-NETWORK_ICONS_DIR = $(shell dirname "$(NETWORK_ICONS_FILE)")
+ifeq ($(TARGET_NAME),$(filter $(TARGET_NAME),TARGET_STAX TARGET_FLEX TARGET_APEX_M TARGET_APEX_P))
+    NETWORK_ICONS_FILE = $(GEN_SRC_DIR)/net_icons.gen.c
+    NETWORK_ICONS_DIR = $(shell dirname "$(NETWORK_ICONS_FILE)")
 
-$(NETWORK_ICONS_FILE):
-	$(shell python3 tools/gen_networks.py "$(NETWORK_ICONS_DIR)")
+    $(NETWORK_ICONS_FILE):
+    	$(shell python3 tools/gen_networks.py "$(NETWORK_ICONS_DIR)")
 
-APP_SOURCE_FILES += $(NETWORK_ICONS_FILE)
+    APP_SOURCE_FILES += $(NETWORK_ICONS_FILE)
 endif
 
 # Application icons following guidelines:
@@ -61,21 +61,25 @@ ICON_NANOX = icons/nanox_app_chain_$(CHAIN_ID).gif
 ICON_NANOSP = icons/nanox_app_chain_$(CHAIN_ID).gif
 ICON_STAX = icons/stax_app_chain_$(CHAIN_ID).gif
 ICON_FLEX = icons/flex_app_chain_$(CHAIN_ID).gif
+ICON_APEX_M = icons/apex_app_chain_$(CHAIN_ID).gif
+ICON_APEX_P = icons/apex_app_chain_$(CHAIN_ID).gif
 
 #prepare hsm generation
 ifeq ($(TARGET_NAME),$(filter $(TARGET_NAME),TARGET_STAX TARGET_FLEX))
     DEFINES += ICONGLYPH=C_chain_$(CHAIN_ID)_64px
     DEFINES += ICONBITMAP=C_chain_$(CHAIN_ID)_64px_bitmap
     DEFINES += ICONHOME=C_chain_$(CHAIN_ID)_64px
-else
-ifeq ($(TARGET_NAME),$(filter $(TARGET_NAME),TARGET_NANOX TARGET_NANOS2))
+else ifeq ($(TARGET_NAME),$(filter $(TARGET_NAME), TARGET_APEX_M TARGET_APEX_P))
+    DEFINES += ICONGLYPH=C_chain_$(CHAIN_ID)_48px
+    DEFINES += ICONBITMAP=C_chain_$(CHAIN_ID)_48px_bitmap
+    DEFINES += ICONHOME=C_chain_$(CHAIN_ID)_48px
+else ifeq ($(TARGET_NAME),$(filter $(TARGET_NAME),TARGET_NANOX TARGET_NANOS2))
     DEFINES += ICONGLYPH=C_chain_$(CHAIN_ID)_14px
     DEFINES += ICONBITMAP=C_chain_$(CHAIN_ID)_14px_bitmap
 
     ICON_HOME_NANO = glyphs/home_chain_$(CHAIN_ID)_14px.gif
     DEFINES += ICONHOME=C_home_chain_$(CHAIN_ID)_14px
 endif
-endif
 
 # Don't define plugin function in the plugin SDK
 DEFINES += IS_NOT_A_PLUGIN

README.md

@@ -40,7 +40,7 @@
 
 ## About the project
 
-Ethereum wallet application framework for Ledger Nano S, Ledger Nano S Plus, Ledger Nano X, Ledger Flex and Ledger Stax.
+Ethereum wallet application framework for Ledger devices.
 Ledger Blue is not maintained anymore, but the app can still be compiled for this target using the branch [`blue-final-release`](https://github.com/LedgerHQ/app-ethereum/tree/blue-final-release).
 
 ## Documentation
@@ -54,9 +54,7 @@ To compile it and load it on a device, please check out our [developer portal](h
 We have the concept of plugins in the ETH app.
 Find the documentations here:
 
-- [Blog Ethereum plugins](https://blog.ledger.com/ethereum-plugins/)
-- [Ethereum application Plugins : Technical Specifications](https://github.com/LedgerHQ/app-ethereum/blob/master/doc/ethapp_plugins.asc)
-- [Plugin guide](https://hackmd.io/300Ukv5gSbCbVcp3cZuwRQ)
+- [Plugin guide](https://ethereum-plugin-sdk.ledger.com)
 - [Boilerplate plugin](https://github.com/LedgerHQ/app-plugin-boilerplate)
 
 ## Quick start guide
@@ -153,6 +151,8 @@ You can choose which device to compile and load for by setting the `BOLOS_SDK` e
 - `BOLOS_SDK=$NANOX_SDK`
 - `BOLOS_SDK=$NANOSP_SDK`
 - `BOLOS_SDK=$STAX_SDK`
+- `BOLOS_SDK=$FLEX_SDK`
+- `BOLOS_SDK=$APEX_P_SDK`
 
 ### Loading on a physical device
 

client/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.6.0] - 2025-09-05
+
+### Added
+
+- Support for Apex devices
+
 ## [0.5.0] - 2025-06-30
 
 ### Added

client/src/ledger_app_clients/ethereum/client.py

@@ -18,6 +18,7 @@
 from .status_word import StatusWord
 from .ledger_pki import PKIClient, PKIPubKeyUsage
 from .dynamic_networks import DynamicNetwork
+from .safe import SafeAccount, AccountType
 
 
 class TrustedNameType(IntEnum):
@@ -35,6 +36,12 @@ class TrustedNameSource(IntEnum):
     DNS = 0x05
 
 
+class EIP712CalldataParamPresence(IntEnum):
+    NONE = 0x00
+    PRESENT_FILTERED = 0x01
+    PRESENT_VERIFYING_CONTRACT = 0x02
+
+
 class SignMode(IntEnum):
     BASIC = 0x00
     STORE = 0x01
@@ -51,7 +58,7 @@ def __init__(self, backend: BackendInterface):
     def _exchange_async(self, payload: bytes):
         return self._backend.exchange_async_raw(payload)
 
-    def _exchange(self, payload: bytes):
+    def _exchange(self, payload: bytes) -> RAPDU:
         return self._backend.exchange_raw(payload)
 
     def response(self) -> Optional[RAPDU]:
@@ -154,6 +161,60 @@ def eip712_filtering_trusted_name(self,
                                                                                     sig,
                                                                                     discarded))
 
+    def eip712_filtering_calldata_info(self,
+                                       index: int,
+                                       value_filter_flag: bool,
+                                       callee_filter_flag: int,
+                                       chain_id_filter_flag: bool,
+                                       selector_filter_flag: bool,
+                                       amount_filter_flag: bool,
+                                       spender_filter_flag: int,
+                                       sig: bytes):
+        return self._exchange(self._cmd_builder.eip712_filtering_calldata_info(index,
+                                                                               value_filter_flag,
+                                                                               callee_filter_flag,
+                                                                               chain_id_filter_flag,
+                                                                               selector_filter_flag,
+                                                                               amount_filter_flag,
+                                                                               spender_filter_flag,
+                                                                               sig))
+
+    def eip712_filtering_calldata_value(self,
+                                        index: int,
+                                        sig: bytes,
+                                        discarded: bool):
+        return self._exchange(self._cmd_builder.eip712_filtering_calldata_value(index, sig, discarded))
+
+    def eip712_filtering_calldata_callee(self,
+                                         index: int,
+                                         sig: bytes,
+                                         discarded: bool):
+        return self._exchange(self._cmd_builder.eip712_filtering_calldata_callee(index, sig, discarded))
+
+    def eip712_filtering_calldata_chain_id(self,
+                                           index: int,
+                                           sig: bytes,
+                                           discarded: bool):
+        return self._exchange(self._cmd_builder.eip712_filtering_calldata_chain_id(index, sig, discarded))
+
+    def eip712_filtering_calldata_selector(self,
+                                           index: int,
+                                           sig: bytes,
+                                           discarded: bool):
+        return self._exchange(self._cmd_builder.eip712_filtering_calldata_selector(index, sig, discarded))
+
+    def eip712_filtering_calldata_amount(self,
+                                         index: int,
+                                         sig: bytes,
+                                         discarded: bool):
+        return self._exchange(self._cmd_builder.eip712_filtering_calldata_amount(index, sig, discarded))
+
+    def eip712_filtering_calldata_spender(self,
+                                          index: int,
+                                          sig: bytes,
+                                          discarded: bool):
+        return self._exchange(self._cmd_builder.eip712_filtering_calldata_spender(index, sig, discarded))
+
     def eip712_filtering_raw(self, name: str, sig: bytes, discarded: bool):
         return self._exchange_async(self._cmd_builder.eip712_filtering_raw(name, sig, discarded))
 
@@ -175,16 +236,19 @@ def serialize_tx(self, tx_params: dict) -> tuple[bytes, bytes]:
         return encoded_tx, tx_hash
 
     def sign(self,
-             bip32_path: str,
-             tx_params: dict,
+             bip32_path: Optional[str] = None,
+             tx_params: Optional[dict] = None,
              mode: SignMode = SignMode.BASIC):
-        tx, _ = self.serialize_tx(tx_params)
-        chunks = self._cmd_builder.sign(bip32_path, tx, mode)
+        if tx_params is None:
+            tx = None
+        else:
+            tx, _ = self.serialize_tx(tx_params)
+        chunks = self._cmd_builder.sign(mode, bip32_path, tx)
         for chunk in chunks[:-1]:
             self._exchange(chunk)
         return self._exchange_async(chunks[-1])
 
-    def get_challenge(self):
+    def get_challenge(self) -> RAPDU:
         return self._exchange(self._cmd_builder.get_challenge())
 
     def get_public_addr(self,
@@ -420,6 +484,12 @@ def provide_transaction_info(self, payload: bytes) -> RAPDU:
             self._exchange(chunk)
         return self._exchange(chunks[-1])
 
+    def provide_transaction_field_desc(self, payload: bytes) -> RAPDU:
+        chunks = self._cmd_builder.provide_transaction_field_desc(payload)
+        for chunk in chunks[:-1]:
+            self._exchange(chunk)
+        return self._exchange(chunks[-1])
+
     def opt_in_tx_simulation(self):
         return self._exchange_async(self._cmd_builder.opt_in_tx_simulation())
 
@@ -454,3 +524,13 @@ def sign_eip7702_authorization(self, bip32_path: str, auth_params: TxAuth7702):
         for chunk in chunks[:-1]:
             self._exchange(chunk)
         return self._exchange_async(chunks[-1])
+
+    def provide_safe_account(self, safe_params: SafeAccount):
+        # Send ledgerPKI certificate - only for SAFE accounts
+        if safe_params.account_type == AccountType.SAFE:
+            self.pki_client.send_certificate(PKIPubKeyUsage.PUBKEY_USAGE_SAFE_ACCOUNT)
+
+        chunks = self._cmd_builder.provide_safe_account(safe_params.serialize(), safe_params.account_type)
+        for chunk in chunks[:-1]:
+            self._exchange(chunk)
+        return self._exchange_async(chunks[-1])