👷 (cs-tester) [DSDK-953]: Add erc7730 nightly job #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
aussedatlo
force-pushed
the
feat/dsdk-953-nightly-cs-tester
branch
from
bbd1096 to
e9e75e0
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a nightly GitHub Actions workflow to test ERC7730-compatible dapps using the clear-signing-tester's raw-file command. The changes include extensive test data for multiple DeFi protocols, improvements to error handling in the clear-signing-tester, and a new automated testing infrastructure.
Key changes:
- New GitHub Actions workflow for nightly ERC7730 testing across multiple devices and protocols
- Added test data files for 13+ protocols including 1inch, Aave, Lido, Uniswap, and others
- Enhanced error state handling with blind signing acknowledgement capability
- Reorganized test resources into core and erc7730 subdirectories
Reviewed changes
Copilot reviewed 45 out of 50 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/erc7730_nightly.yml |
New workflow for nightly ERC7730 testing with matrix strategy for devices and providers |
apps/clear-signing-tester/src/infrastructure/state-handlers/ErrorStateHandler.ts |
Added blind signing acknowledgement fallback in error handling |
apps/clear-signing-tester/src/infrastructure/services/DefaultScreenAnalyzer.ts |
Implemented canAcknowledgeBlindSigning() method |
apps/clear-signing-tester/src/domain/services/ScreenAnalyzer.ts |
Added interface method for blind signing acknowledgement |
apps/clear-signing-tester/package.json |
Updated test scripts and added new test:erc7730 command |
apps/clear-signing-tester/src/infrastructure/adapters/evm/EthersTransactionCrafter.ts |
Added debug logging for transaction data |
packages/device-management-kit/src/internal/discovery/use-case/ConnectUseCase.ts |
Simplified error logging by removing detailed error data |
apps/clear-signing-tester/src/infrastructure/adapters/speculos/SpeculosScreenReader.ts |
Simplified error logging in screen reading |
apps/clear-signing-tester/ressources/erc7730/* |
Added comprehensive test data files for 13 protocols across multiple chains |
apps/clear-signing-tester/ressources/core/* |
Moved and added core test data files |
apps/clear-signing-tester/scripts/*.sh |
New utility scripts for fetching transaction data |
apps/clear-signing-tester/scripts/test-full.mjs |
Removed file (test organization changed) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/clear-signing-tester/src/infrastructure/services/DefaultScreenAnalyzer.ts
Show resolved
Hide resolved
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Contributor
| @@ -0,0 +1,2 @@ | |||
| # <div class="d-inline"><span class="d-inline"><i class="far fa-memo text-secondary " data-bs-toggle="tooltip" data-bs-title="Contract"></i> <a data-highlight-value data-highlight-target="0x7d2768de32b0b80b7a3454c06bdac94a69ddc7a9" href="/address/0x7d2768de32b0b80b7a3454c06bdac94a69ddc7a9" class="text-break" style="word-break: break-all!important;"><span id='data-tadd'>0x7d2768dE32b0b80b7a3454c06BdAc94A69DDc7A9</span></a></span> <span>(Aave: Lending Pool V2)</span> <a class="js-clipboard link-secondary me-1" href="javascript:;" data-clipboard-text="0x7d2768dE32b0b80b7a3454c06BdAc94A69DDc7A9" data-bs-toggle="tooltip" title="Copy Address" data-hs-clipboard-options='{ | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # <div class="d-inline"><span class="d-inline"><i class="far fa-memo text-secondary " data-bs-toggle="tooltip" data-bs-title="Contract"></i> <a data-highlight-value data-highlight-target="0x7d2768de32b0b80b7a3454c06bdac94a69ddc7a9" href="/address/0x7d2768de32b0b80b7a3454c06bdac94a69ddc7a9" class="text-break" style="word-break: break-all!important;"><span id='data-tadd'>0x7d2768dE32b0b80b7a3454c06BdAc94A69DDc7A9</span></a></span> <span>(Aave: Lending Pool V2)</span> <a class="js-clipboard link-secondary me-1" href="javascript:;" data-clipboard-text="0x7d2768dE32b0b80b7a3454c06BdAc94A69DDc7A9" data-bs-toggle="tooltip" title="Copy Address" data-hs-clipboard-options='{ |
pdeville-ledger
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add nightly job to test erc7730 compatible dapps with cs-teser raw-file command.
Fix a small edge case with aknoledge blind signing to ensure the device can refuse to avoid closing the app and killing speculos.
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers