Skip to content

Conversation

@fAnselmi-Ledger
Copy link
Contributor

@fAnselmi-Ledger fAnselmi-Ledger commented Dec 15, 2025

πŸ“ BTC device action steps

Added steps in BTC signer device action's intermediate values

❓ Context

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Documentation is up-to-date
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copilot AI review requested due to automatic review settings December 15, 2025 14:12
@fAnselmi-Ledger fAnselmi-Ledger requested a review from a team as a code owner December 15, 2025 14:12
@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
device-sdk-ts-sample Ready Ready Preview, Comment Dec 15, 2025 2:35pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
doc-device-management-kit Ignored Ignored Dec 15, 2025 2:35pm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds step tracking to Bitcoin signer device actions, enabling consumers to monitor the progress of multi-step operations. Each device action now includes a step field in its intermediate values alongside the existing requiredUserInteraction field, providing more granular visibility into the state machine's progress.

  • Adds step enums and types to three device action type definitions (SignPsbt, SignTransaction, GetWalletAddress)
  • Updates device action implementations to set and maintain step values throughout state transitions
  • Updates all corresponding test files to assert correct step values in intermediate values
  • Includes minor refactoring for consistency (converting object returns to arrow function shorthand, simplifying array wrapping for actions)

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/signer/signer-btc/src/api/app-binder/SignTransactionDeviceActionTypes.ts Adds signTransactionDAStateSteps enum and includes step field in SignTransactionDAIntermediateValue type
packages/signer/signer-btc/src/api/app-binder/SignPsbtDeviceActionTypes.ts Adds signPsbtDAStateSteps enum and includes step field in SignPsbtDAIntermediateValue type
packages/signer/signer-btc/src/api/app-binder/GetWalletAddressDeviceActionTypes.ts Adds getWalletAddressDAStateSteps enum and includes step field in GetWalletAddressDAIntermediateValue type
packages/signer/signer-btc/src/internal/app-binder/device-action/SignTransaction/SignTransactionDeviceAction.ts Updates state machine to set step values in context initialization and state entry/exit actions; refactors action assignments for consistency
packages/signer/signer-btc/src/internal/app-binder/device-action/SignPsbt/SignPsbtDeviceAction.ts Updates state machine to set step values in context initialization and state entry actions; refactors action assignments and object returns
packages/signer/signer-btc/src/internal/app-binder/device-action/GetWalletAddress/GetWalletAddressDeviceAction.ts Updates state machine to set step values in context initialization and state entry actions; refactors action assignments and object returns
packages/signer/signer-btc/src/internal/app-binder/device-action/SignTransaction/SignTransactionDeviceAction.test.ts Updates test expectations to include step values in all intermediate value assertions
packages/signer/signer-btc/src/internal/app-binder/device-action/SignPsbt/SignPsbtDeviceAction.test.ts Updates test expectations to include step values in all intermediate value assertions
packages/signer/signer-btc/src/internal/app-binder/device-action/GetWalletAddress/GetWalletAddressDeviceAction.test.ts Updates test expectations to include step values in all intermediate value assertions
.changeset/plenty-books-teach.md Adds changeset for minor version bump documenting the new feature

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/dsdk-933-btc-da-steps branch from 822bef9 to 8e835c9 Compare December 15, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants