Bug / Incorrect parameter in some of the SignerEthBuilder examples
#863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
The PR corrects the parameter name in SignerEthBuilder usage examples from sdk to dmk to match the actual constructor signature.
- Updated the default and customized context module examples to use
dmkinstead ofsdkin the README. - Applied the same fix in the MDX reference documentation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/signer/signer-eth/README.md | Changed { sdk, sessionId } to { dmk, sessionId } in examples |
| apps/docs/pages/docs/references/signers/eth.mdx | Updated example to use dmk parameter instead of sdk |
mbertin-ledger
approved these changes
Jun 7, 2025
Member
mbertin-ledger
left a comment
mbertin-ledger
left a comment
There was a problem hiding this comment.
Thx for contributing 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR updates the usage example of SignerEthBuilder:
The correct parameter name is dmk, not sdk. This change aligns the example with the actual constructor signature.
Changelog