implement rust flag checking logic

Author: mbrousset-ledger

config/forbidden-flags.json

@@ -6,7 +6,7 @@
         "PRODUCTION_BUILD=0"
     ],
     "rust":[
-        "TBD"
+        "debug = true"
     ]
   }
 }

scripts/check_all.sh

@@ -218,7 +218,7 @@ call_step() {
             COMMAND="python3 ${DATABASE_DIR}/scripts/app_load_params_check.py --database_path ${DATABASE_DIR}/app-load-params-db.json --app_manifests_path ${MANIFEST_DIR}"
             ;;
         "makefile")
-            COMMAND="${dirName}/check_makefile.sh ${APP_DIR} ${REPO_NAME} ${MANIFEST_DIR} ${WORKFLOWS_DIR} ${TARGET}"
+            COMMAND="${dirName}/check_makefile.sh ${APP_DIR} ${REPO_NAME} ${MANIFEST_DIR} ${WORKFLOWS_DIR} ${IS_RUST} ${TARGET}"
             ;;
         "readme")
             COMMAND="${dirName}/check_readme.sh ${APP_DIR} ${REPO_NAME}"

scripts/check_makefile.sh

@@ -11,7 +11,8 @@ main() (
     repo_name="$2"
     manifests_dir="$3"
     workflows_dir="$4"
-    target="$5"
+    is_rust="$5"
+    target="$6"
 
     declare -A variants_array
     declare -A appnames_array
@@ -95,44 +96,62 @@ main() (
 
     # check if there are no forbidden compilation flags (e.g. debug flags)
     forbidden_flags_file="${workflows_dir}/config/forbidden-flags.json"
-    forbidden_flags=$(jq -r '.forbidden.c[]' "$forbidden_flags_file")
-
-    entrypoint_filepath=$(grep -rP \
-        --exclude-dir='deps' \
-        --exclude-dir='tests' \
-        --exclude-dir='vendor' \
-        --include='*.c' \
-        '\b(app_)?main\s*\([^)]*\)' . | cut -d':' -f1 | head -n1)
-    entrypoint_filepath=${entrypoint_filepath#./}
-    entrypoint_filepath=${entrypoint_filepath%.c}.o
-
-    build_dir=$(ledger-manifest -ob ledger_app.toml)
-    if [ -n "${build_dir}" ]; then
-        for cur_manifest in $manifests_list; do
-            for variant in "${!variants_array[@]}"; do
-                build_target=$(jq -r ".VARIANTS.${variant}.TARGET" "${cur_manifest}")
-                eval "BOLOS_SDK=\$$(echo "${build_target/s2/sp}" | tr '[:lower:]' '[:upper:]')_SDK"
-
-                log_info "Trying to make --dry-run for rule build/${build_target}/obj/app/${entrypoint_filepath}. Using $BOLOS_SDK"
-
-                make -C "${build_dir}"  \
-                    BOLOS_SDK="${BOLOS_SDK}" \
-                    --dry-run build/"${build_target}"/obj/app/"${entrypoint_filepath}" 2>&1 | tee build_dry_run_output.txt
-
-                for forbidden_flag in $forbidden_flags; do
-                    log_info "Checking for forbidden flag $forbidden_flag"
-                    if grep -q "$forbidden_flag" build_dry_run_output.txt; then
-                        log_error_no_header "Detected forbidden flag $forbidden_flag in build output."
-                        error=1
-                    else
-                        log_info "Did not find forbidden flag $forbidden_flag in build output."
-                    fi
+
+    if [[ ${is_rust} == true ]]; then
+        echo "$RUSTFLAGS" > env_rustflags.txt
+
+        forbidden_flags=$(jq -r '.forbidden.rust[]' "$forbidden_flags_file")
+
+        while IFS= read -r forbidden_flag; do
+            echo "Checking flag $forbidden_flag"
+            if grep -q "$forbidden_flag" Cargo.toml .cargo/config.toml env_rustflags.txt; then
+                log_error_no_header "Detected forbidden flag $forbidden_flag in build output."
+                error=1
+            else
+                log_info "Did not find forbidden flag $forbidden_flag in build output."
+            fi
+        done <<< "$forbidden_flags"
+    else
+        forbidden_flags=$(jq -r '.forbidden.c[]' "$forbidden_flags_file")
+
+        entrypoint_filepath=$(grep -rP \
+            --exclude-dir='deps' \
+            --exclude-dir='tests' \
+            --exclude-dir='vendor' \
+            --include='*.c' \
+            '\b(app_)?main\s*\([^)]*\)' . | cut -d':' -f1 | head -n1)
+        entrypoint_filepath=${entrypoint_filepath#./}
+        entrypoint_filepath=${entrypoint_filepath%.c}.o
+
+        build_dir=$(ledger-manifest -ob ledger_app.toml)
+        if [ -n "${build_dir}" ]; then
+            for cur_manifest in $manifests_list; do
+                for variant in "${!variants_array[@]}"; do
+                    build_target=$(jq -r ".VARIANTS.${variant}.TARGET" "${cur_manifest}")
+                    eval "BOLOS_SDK=\$$(echo "${build_target/s2/sp}" | tr '[:lower:]' '[:upper:]')_SDK"
+
+                    log_info "Trying to make --dry-run for rule build/${build_target}/obj/app/${entrypoint_filepath}. Using $BOLOS_SDK"
+
+                    make -C "${build_dir}"  \
+                        BOLOS_SDK="${BOLOS_SDK}" \
+                        --dry-run build/"${build_target}"/obj/app/"${entrypoint_filepath}" 2>&1 | tee build_dry_run_output.txt
+
+                    for forbidden_flag in $forbidden_flags; do
+                        log_info "Checking for forbidden flag $forbidden_flag"
+                        if grep -q "$forbidden_flag" build_dry_run_output.txt; then
+                            log_error_no_header "Detected forbidden flag $forbidden_flag in build output."
+                            error=1
+                        else
+                            log_info "Did not find forbidden flag $forbidden_flag in build output."
+                        fi
+                    done
                 done
             done
-        done
-    else
-        log_error_no_header "build directory not found in ledger_app.toml!" >&2
-        error=1
+        else
+            log_error_no_header "build directory not found in ledger_app.toml!" >&2
+            error=1
+        fi
+
     fi
 
     if [[ error -eq 0 ]]; then