Skip to content

add geometry check for glyphs #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add geometry check for glyphs #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions scripts/check_icons.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,38 @@
error=0
file="$1"
device="$2"
type="$3"

case "$device" in
nanos)
case "$device:$type" in
nanos:icon | nanos:glyph)
geometry="16x16"
;;
nanox | nanos2)
nanox:icon | nanos2:icon | nanox:glyph | nanos2:glyph)
geometry="14x14"
;;
stax | apex | apex_m | apex_p)
stax:icon | apex:icon | apex_m:icon | apex_p:icon)
geometry="32x32"
;;
flex)
apex:glyph | apex_m:glyph | apex_p:glyph)
geometry="48x48"
;;
stax:glyph | flex:glyph)
geometry="64x64"
;;
flex:icon)
geometry="40x40"
;;
*)
log_error "Device '$device' not recognized"
log_error "Combinaison device='$device' and type='$type' not recognized"

Check failure on line 35 in scripts/check_icons.sh

View workflow job for this annotation

GitHub Actions / Check misspellings 

Combinaison ==> Combination
return 1
;;
esac

if ! identify -verbose "$file" | grep -q "Geometry: $geometry"; then
log_error "Icon '$file' used for '$device' should have a '$geometry' geometry"
log_error "'$type' '$file' used for '$device' should have a '$geometry' geometry"
error=1
else
log_success "Icon '$file' used for '$device' has a correct '$geometry' geometry"
log_success "'$type' '$file' used for '$device' has a correct '$geometry' geometry"
fi

return "$error"
Expand Down Expand Up @@ -144,7 +151,7 @@
check_is_not_boilerplate_icon "$file" || error=1
fi

check_geometry "$file" "$device" || error=1
check_geometry "$file" "$device" "icon" || error=1

check_glyph "$file" || error=1

Expand Down Expand Up @@ -226,7 +233,8 @@
error=1
continue
fi
check_glyph "$repo/$build_directory/$file" || error=1
check_glyph "$img_file" || error=1
check_geometry "$img_file" "$device" "glyph" || error=1
fi
done < <(echo "$all_glyph_files_no_duplicates")

Expand Down
Loading