Skip to content

Y333/apex support #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Aug 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
8e64ce2
Read target cflags from external files
yogh333 Jul 22, 2025
df0282f
Use same cflags as C SDK compilation
yogh333 Jul 23, 2025
af9f8dd
Use same defines as C SDK build
yogh333 Jul 23, 2025
bda22d6
Rename C SDK defines files
yogh333 Jul 23, 2025
f5e6662
Keep only -Wno-unused-command-line-argument when bulding C SDK
yogh333 Jul 24, 2025
4264057
Debug C SDK (PRINTF) as a feature
yogh333 Jul 24, 2025
6ef0c93
Add new workflow to check C SDK build parameters (CFLAGS, DEFINES)
yogh333 Jul 24, 2025
47b7b3c
Add PR trigger for the new workflow
yogh333 Jul 24, 2025
259e0de
Update linker layout scripts for Nano S+, Stax, Flex so they match wi…
yogh333 Aug 4, 2025
8baa856
Fix defines for S+ and X when BAGL is used
yogh333 Aug 5, 2025
b86abe3
Fix bindings
yogh333 Aug 5, 2025
ada8378
Run cargo fmt + update check C SDK build parameters workflow
yogh333 Aug 5, 2025
928b75a
Fix CI
yogh333 Aug 5, 2025
fac821f
CI: add permissions
yogh333 Aug 5, 2025
ab8ff3b
Add APEX_P files
yogh333 Aug 5, 2025
437043c
apex_p target support in SDK crates
yogh333 Aug 5, 2025
bcab002
Run cargo fmt
yogh333 Aug 6, 2025
0522557
Update bindgen + cleanup binding generation
yogh333 Aug 6, 2025
406c8d5
Run cargo fmt
yogh333 Aug 6, 2025
5dc5c59
Update reusable build all rust apps workflow
yogh333 Aug 6, 2025
023a559
Revert bindgen upgrade
yogh333 Aug 6, 2025
818f5d3
fix revert bindgen
yogh333 Aug 6, 2025
1c5ce34
Generate BAGL glyphs
yogh333 Aug 7, 2025
ce5e606
Use BAGL glyphs from C SDK (except 2 as it may impact UI for client a…
yogh333 Aug 7, 2025
a2979b1
More explicit #[cfg] according to the targeted device
yogh333 Aug 8, 2025
179464d
Put target files into dedicated folders
yogh333 Aug 8, 2025
9a9b491
Added missing target files
yogh333 Aug 8, 2025
68315f5
Update CheckC SDK build parameters workflow
yogh333 Aug 13, 2025
bda148f
Fix workflow
yogh333 Aug 13, 2025
2f8d336
Fix workflow again
yogh333 Aug 13, 2025
fcc3974
Bump versions
yogh333 Aug 14, 2025
939b544
Fix sys crate version
yogh333 Aug 14, 2025
4b98f24
Fix build all rust apps workflow
yogh333 Aug 14, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/workflows/check_csdk_build_parameters.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Build C Boilerplate application and check if C SDK build parameters are still correct
permissions:
contents: read

on:
pull_request:
workflow_dispatch:
schedule:
# * is a special character in YAML so you have to quote this string
- cron: '0 12 * * *'

jobs:
check_csdk_build_parameters:
runs-on: ubuntu-latest
container:
image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder:latest
strategy:
matrix:
target: ["nanox", "nanosplus", "stax", "flex", "apex_p"]
steps:
- name: Checkout C BP
uses: actions/checkout@v4
with:
repository: LedgerHQ/app-boilerplate
path: c_boilerplate
- name: Checkout C SDK Build Parameters Extractor
uses: actions/checkout@v4
with:
repository: LedgerHQ/csdk_build_parameters_extractor
path: c_sdk_build_params_x
- name: Build C SDK Build Parameters Extractor
run: |
cd c_sdk_build_params_x
cargo build --release
- name: Run C SDK Build Parameters Extractor
run: |
cd c_sdk_build_params_x
./target/release/cbpx --app-path ../c_boilerplate \
--device ${{ matrix.target }}
if [ $? -ne 0 ]; then
echo "C SDK build parameters do not match with ref ones for target ${{ matrix.target }}"
exit 1
fi
13 changes: 9 additions & 4 deletions .github/workflows/reusable_build_all_apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ jobs:
cd ${{ matrix.app-name }}
build_directory=$(ledger-manifest --output-build-directory ledger_app.toml)
cd $build_directory
# Required as patch has a different version from what is locked in Cargo.lock
cargo update include_gif
cargo update ledger_secure_sdk_sys
cargo update ledger_device_sdk

workspace_root=$(cargo metadata --no-deps --format-version 1 | jq -r '.workspace_root')
cargo_toml_path="$workspace_root/Cargo.toml"

Expand Down Expand Up @@ -121,6 +126,9 @@ jobs:
echo "Cargo.toml:"
cat $cargo_toml_path

cargo update include_gif
cargo update ledger_secure_sdk_sys
cargo update ledger_device_sdk
- name: Build
run: |
# Clone C SDK if provided
Expand All @@ -134,10 +142,7 @@ jobs:
cd ${{ matrix.app-name }}
build_directory=$(ledger-manifest --output-build-directory ledger_app.toml)
cd $build_directory
# Use last published versions of the Rust SDK
cargo update include_gif
cargo update ledger_secure_sdk_sys
cargo update ledger_device_sdk
echo "Building app for ${{ matrix.device }}"
device=$(echo ${{ matrix.device }} | sed 's/+/plus/')
echo "Build for "$device
cargo ledger build $device
178 changes: 129 additions & 49 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading