Skip to content

Commit cb67e47

Browse files
iqbalibrahim-ledgeriqbalibrahim-ledger
committed
feat(lwd,lwm): removed llMevProtection feature flag, updated i18n files with mev url
1 parent fe6438f commit cb67e47

File tree

31 files changed

+51
-40
lines changed

31 files changed

+51
-40
lines changed

‎.changeset/mighty-rockets-play.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
"@ledgerhq/types-live": minor
3+
"ledger-live-desktop": minor
4+
"live-mobile": minor
5+
"@ledgerhq/live-common": minor
6+
---
7+
8+
feat(lwd,lwm): removed llMevProtection feature flag, updated i18n files with mev url

‎apps/ledger-live-desktop/src/renderer/analytics/segment.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,11 @@ const getLedgerSyncAttributes = (state: State) => {
9898

9999
const getMEVAttributes = (state: State) => {
100100
if (!analyticsFeatureFlagMethod) return false;
101-
const mevProtection = analyticsFeatureFlagMethod("llMevProtection");
102101

103102
const hasMEVActivated = mevProtectionSelector(state);
104103

105104
return {
106-
MEVProtectionActivated: !mevProtection?.enabled ? "Null" : hasMEVActivated ? "Yes" : "No",
105+
MEVProtectionActivated: hasMEVActivated ? "Yes" : "No",
107106
};
108107
};
109108

‎apps/ledger-live-desktop/src/renderer/screens/settings/sections/General/index.tsx‎

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@ const SectionGeneral = () => {
3131
const { t } = useTranslation();
3232
useInitSupportedCounterValues();
3333
const lldAnalyticsOptInPromptFlag = useFeature("lldAnalyticsOptInPrompt");
34-
const llMevProtectionFeatureFlag = useFeature("llMevProtection");
3534
const { shouldDisplayEntryPoint } = useEntryPoint(EntryPoint.settings);
36-
const mevLearnMoreLink = llMevProtectionFeatureFlag?.params?.link?.trim() || undefined;
3735
const { closeDrawer } = useActivationDrawer();
3836
const ledgerSyncOptimisationFlag = useFeature("lwdLedgerSyncOptimisation");
3937

@@ -118,18 +116,16 @@ const SectionGeneral = () => {
118116
</Row>
119117
) : null}
120118

121-
<FeatureToggle featureId="llMevProtection">
122-
<Row
123-
title={t("settings.display.mevProtection")}
124-
desc={t("settings.display.mevProtectionDesc")}
125-
dataTestId="setting-mevProtection"
126-
id="setting-mevProtection"
127-
linkText={t("settings.display.mevProtectionLearnMore")}
128-
externalUrl={mevLearnMoreLink}
129-
>
130-
<MevProtectionRow />
131-
</Row>
132-
</FeatureToggle>
119+
<Row
120+
title={t("settings.display.mevProtection")}
121+
desc={t("settings.display.mevProtectionDesc")}
122+
dataTestId="setting-mevProtection"
123+
id="setting-mevProtection"
124+
linkText={t("settings.display.mevProtectionLearnMore")}
125+
externalUrl={t("settings.display.mevProtectionLearnMoreUrl")}
126+
>
127+
<MevProtectionRow />
128+
</Row>
133129

134130
<Row
135131
title={t("settings.profile.reportErrors")}

‎apps/ledger-live-desktop/static/i18n/ar/app.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4497,6 +4497,7 @@
44974497
"mevProtection" : "حماية الحد الأقصى للقيمة القابلة للاستخراج (MEV)",
44984498
"mevProtectionDesc" : "قم بتمكين حماية الحد الأقصى للقيمة القابلة للاستخراج (MEV) لمعاملات أكثر موثوقية على إيثريوم.",
44994499
"mevProtectionLearnMore" : "إشعار الخصوصية",
4500+
"mevProtectionLearnMoreUrl": "https://support.ledger.com/ar/article/How-to-protect-your-transactions-from-Maximal-Extractable-Value-MEV-attacks",
45004501
"marketPerformanceWidget" : "أداة أداء السوق",
45014502
"marketPerformanceWidgetDesc" : "قم بتمكين هذه الميزة لعرض أعلى الرابحين وأعلى الخاسرين خلال الفترات الزمنية المختارة في صفحة المحفظة الاستثمارية."
45024503
},

‎apps/ledger-live-desktop/static/i18n/de/app.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4497,6 +4497,7 @@
44974497
"mevProtection" : "MEV-Schutz",
44984498
"mevProtectionDesc" : "Aktiviere den MEV-Schutz, um die Zuverlässigkeit von Ethereum-Transaktionen zu verbessern.",
44994499
"mevProtectionLearnMore" : "Datenschutzerklärung",
4500+
"mevProtectionLearnMoreUrl": "https://support.ledger.com/de/article/How-to-protect-your-transactions-from-Maximal-Extractable-Value-MEV-attacks",
45004501
"marketPerformanceWidget" : "Marktperformance-Widget",
45014502
"marketPerformanceWidgetDesc" : "Aktiviere diese Funktion, um auf der Portfolioseite die größten Gewinner und Verlierer über ausgewählte Zeiträume anzuzeigen."
45024503
},

‎apps/ledger-live-desktop/static/i18n/en/app.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4536,6 +4536,7 @@
45364536
"mevProtection": "MEV Protection",
45374537
"mevProtectionDesc": "Enable MEV Protection for more reliable transactions on Ethereum.",
45384538
"mevProtectionLearnMore": "Privacy notice",
4539+
"mevProtectionLearnMoreUrl": "https://support.ledger.com/article/How-to-protect-your-transactions-from-Maximal-Extractable-Value-MEV-attacks",
45394540
"marketPerformanceWidget": "Market Performance Widget",
45404541
"marketPerformanceWidgetDesc": "Enable this feature to view the top gainers and losers over selected timeframes on the portfolio page."
45414542
},

‎apps/ledger-live-desktop/static/i18n/es/app.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4497,6 +4497,7 @@
44974497
"mevProtection" : "Protección contra MEV",
44984498
"mevProtectionDesc" : "Activa la Protección contra MEV para lograr transacciones más fiables en Ethereum.",
44994499
"mevProtectionLearnMore" : "Aviso de privacidad",
4500+
"mevProtectionLearnMoreUrl": "https://support.ledger.com/es/article/How-to-protect-your-transactions-from-Maximal-Extractable-Value-MEV-attacks",
45004501
"marketPerformanceWidget" : "Widget de rendimiento del mercado",
45014502
"marketPerformanceWidgetDesc" : "Activa esta opción para ver los principales ganadores y perdedores en los periodos que selecciones en la página del portfolio."
45024503
},

‎apps/ledger-live-desktop/static/i18n/fr/app.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4497,6 +4497,7 @@
44974497
"mevProtection" : "Protection MEV",
44984498
"mevProtectionDesc" : "Activez la protection contre la MEV pour des transactions plus fiables sur Ethereum.",
44994499
"mevProtectionLearnMore" : "Avis de confidentialité",
4500+
"mevProtectionLearnMoreUrl": "https://support.ledger.com/fr/article/How-to-protect-your-transactions-from-Maximal-Extractable-Value-MEV-attacks",
45004501
"marketPerformanceWidget" : "Widget de suivi du marché",
45014502
"marketPerformanceWidgetDesc" : "Activez cette fonctionnalité pour afficher sur la page Portefeuille le Top des hausses et le Top des baisses sur une période choisie."
45024503
},

‎apps/ledger-live-desktop/static/i18n/ja/app.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4497,6 +4497,7 @@
44974497
"mevProtection" : "MEV保護",
44984498
"mevProtectionDesc" : "MEV保護を有効にすると、イーサリアムでのトランザクションの信頼性が高まります。",
44994499
"mevProtectionLearnMore" : "プライバシーに関する通知",
4500+
"mevProtectionLearnMoreUrl": "https://support.ledger.com/ja/article/How-to-protect-your-transactions-from-Maximal-Extractable-Value-MEV-attacks",
45004501
"marketPerformanceWidget" : "マーケットパフォーマンスウィジェット",
45014502
"marketPerformanceWidgetDesc" : "この機能を有効化すると、ポートフォリオページで選択した時間枠の、上昇率上位と下落率上位が表示されます。"
45024503
},

‎apps/ledger-live-desktop/static/i18n/ko/app.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4497,6 +4497,7 @@
44974497
"mevProtection" : "MEV 보호",
44984498
"mevProtectionDesc" : "MEV 보호 기능을 활성화하여 이더리움을 보다 안정적으로 거래하세요",
44994499
"mevProtectionLearnMore" : "개인정보 관련 고지",
4500+
"mevProtectionLearnMoreUrl": "https://support.ledger.com/ko/article/How-to-protect-your-transactions-from-Maximal-Extractable-Value-MEV-attacks",
45004501
"marketPerformanceWidget" : "마켓 퍼포먼스 위젯",
45014502
"marketPerformanceWidgetDesc" : "이 기능을 활성화하면 포트폴리오 페이지에서 선택한 기간 동안 가장 큰 상승 및 하락을 기록한 코인을 확인할 수 있습니다."
45024503
},

0 commit comments

Comments
 (0)