Feature/live 20724 [LLD][UI] Memo screen #13505

Moustafa-Koterba · 2025-12-31T15:04:46Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- New memo field in the recipient step, behaviour change

📝 Description

What does this PR do ?

This PR implements the memo management in the new Send flow.

Context

Some chain implements a system of memo like for fiat transaction which allow to add a string to a string.
We need to implement this into the new Send flow.

What have changed

An input for the memo in the recipient step
Hooks for business logic
An account settings to not ask confirmation on skipping memo

Screenshots

❓ Context

JIRA or GitHub link: LIVE-20724

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2025-12-31T15:04:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
ledger-live-github-bot	Ignored	Preview	Jan 29, 2026 11:30am
native-ui-storybook	Ignored	Preview	Jan 29, 2026 11:30am
react-ui-storybook	Ignored	Preview	Jan 29, 2026 11:30am
web-tools	Ignored	Preview	Jan 29, 2026 11:30am

live-github-bot · 2026-01-26T17:13:35Z

Desktop Bundle Checks

Comparing d94203c against a6100ec.

✅ Previous issues have all been fixed.

Mobile Bundle Checks

Comparing d94203c against a6100ec.

✅ Previous issues have all been fixed.

dilaouid · 2026-01-27T13:16:46Z

apps/ledger-live-desktop/src/mvvm/features/Send/components/SendHeader.tsx

+import { useRecipientMemo } from "../screens/Recipient/hooks/useRecipientMemo";
 import { SEND_FLOW_STEP, type SendFlowStep, type SendStepConfig } from "../types";
 import { getRecipientDisplayValue, getRecipientSearchPrefillValue } from "./utils";
-import { useAvailableBalance } from "../hooks/useAvailableBalance";


You can keep the import instead of adding the whole function inside the file

dilaouid · 2026-01-27T13:17:05Z

apps/ledger-live-desktop/src/mvvm/features/Send/components/SendHeader.tsx

    t,
+    showMemoControls,
+    currencyId,
+    memoViewModel.showMemoValueInput,


Can we regroup thoses props?

dilaouid · 2026-01-27T13:23:27Z

...-desktop/src/mvvm/features/Send/screens/Recipient/hooks/useRecipientAddressModalViewModel.ts

+        }
+
+        const address = entry.address;
+        const ensName = typeof entry.ensName === "string" ? entry.ensName : undefined;


Why the adds of all thoses isRecord / typeof checks ?

old code, issue with commit hash, I had a previous version of the send flow, fixed now !

gre-ledger · 2026-01-27T13:30:50Z

.zed/debug.json

+//
+// For more documentation on how to configure debug tasks,
+// see: https://zed.dev/docs/debugger
+[]


accidental file?

yes, added to gitignore

github-actions · 2026-01-28T11:20:58Z

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

Select "Run workflow"
Branch: feature/LIVE-20724
Device: nanoSP or stax

📱 Mobile

-> Run Mobile E2E

Select "Run workflow"
Branch: feature/LIVE-20724
Device: nanoX

mcayuelas-ledger · 2026-01-28T13:17:30Z

apps/ledger-live-desktop/src/mvvm/features/Send/components/SendHeader.tsx

Your SendHeader should use MVVM at this stage IMO

Done. I will add unit test in an other PR for the new hook 👍

mcayuelas-ledger · 2026-01-28T13:18:09Z

apps/ledger-live-desktop/src/mvvm/features/Send/hooks/useSendFlowState.ts

      setRecipient(recipient);
      transactionHook.actions.setRecipient(recipient);
+      setRecipient(prev => (prev ? { ...prev, ...recipient } : recipient));


why do it 2 times?

mcayuelas-ledger · 2026-01-28T13:19:05Z

...r-live-desktop/src/mvvm/features/Send/screens/Recipient/components/AddressMatchedSection.tsx

-  const getRecentDescription = (): string => {
+  const getRecentDescription = (): string | undefined => {
    if (matchedRecentAddress) {
      return `Already used · ${formatRelativeDate(matchedRecentAddress.lastUsedAt)}`;


should be translated no?

…gation back + different fixes

sonarqubecloud · 2026-01-28T17:41:04Z

Quality Gate failed

Failed conditions
16.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

mcayuelas-ledger · 2026-01-29T08:58:39Z

/generate-screenshots

Moustafa-Koterba · 2026-01-29T10:05:56Z

/generate-screenshots

Moustafa-Koterba · 2026-01-29T10:06:38Z

E2E

Moustafa-Koterba · 2026-01-29T10:13:32Z

@Moustafa-Koterba

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

github-actions bot assigned Moustafa-Koterba Dec 31, 2025

live-github-bot bot added desktop Has changes in LLD common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Dec 31, 2025

vercel bot deployed to Preview – web-tools December 31, 2025 15:08 View deployment

dilaouid force-pushed the feature/LIVE-20724 branch from c2c5014 to e6209fb Compare January 20, 2026 16:53

live-github-bot bot removed the ledgerjs Has changes in the ledgerjs open source libs label Jan 20, 2026

dilaouid force-pushed the feature/LIVE-20724 branch from e6209fb to e366821 Compare January 20, 2026 16:54

vercel bot deployed to Preview – web-tools January 20, 2026 16:56 View deployment

dilaouid force-pushed the feature/LIVE-20724 branch from e366821 to 2fa9d7d Compare January 20, 2026 17:24

vercel bot deployed to Preview – web-tools January 20, 2026 17:26 View deployment

dilaouid force-pushed the feature/LIVE-20724 branch from 2fa9d7d to 58c6911 Compare January 21, 2026 09:16

vercel bot deployed to Preview – web-tools January 21, 2026 09:18 View deployment

dilaouid force-pushed the feature/LIVE-20724 branch from 58c6911 to 2991f8c Compare January 21, 2026 10:07

vercel bot deployed to Preview – web-tools January 21, 2026 10:09 View deployment

Moustafa-Koterba force-pushed the feature/LIVE-20724 branch 5 times, most recently from e797503 to 8ce386f Compare January 26, 2026 16:56

Moustafa-Koterba force-pushed the feature/LIVE-20724 branch 3 times, most recently from 933cb0c to 19766e7 Compare January 27, 2026 10:01

Moustafa-Koterba marked this pull request as ready for review January 27, 2026 13:12

Moustafa-Koterba requested review from a team as code owners January 27, 2026 13:12

dilaouid reviewed Jan 27, 2026

View reviewed changes

gre-ledger reviewed Jan 27, 2026

View reviewed changes

Moustafa-Koterba force-pushed the feature/LIVE-20724 branch from 19766e7 to 0097800 Compare January 28, 2026 11:18

dilaouid previously approved these changes Jan 28, 2026

View reviewed changes

mcayuelas-ledger reviewed Jan 28, 2026

View reviewed changes

dilaouid dismissed their stale review via 1ca9dbe January 28, 2026 14:27

feat(desktop): [LLD][UI] Memo screen (new send flow - LIVE-20724)

f09dbac

vercel bot deployed to Preview – native-ui-storybook January 28, 2026 14:29 View deployment

vercel bot deployed to Preview – web-tools January 28, 2026 14:29 View deployment

dilaouid and others added 4 commits January 28, 2026 15:30

feat: refacto / fix conflicts / update banner

4bc7b5e

feat: implement settings for dont show again + fix reset memo on navi…

0c8b3d8

…gation back + different fixes

PR reviews

97d20cb

feat(desktop): reviews + reset code to develop

3e663e2

dilaouid force-pushed the feature/LIVE-20724 branch 2 times, most recently from 6c962c4 to f1209ce Compare January 28, 2026 14:39

vercel bot deployed to Preview – web-tools January 28, 2026 14:41 View deployment

feat(desktop): fix knip.json

8feb951

dilaouid force-pushed the feature/LIVE-20724 branch from f1209ce to 8feb951 Compare January 28, 2026 14:45

vercel bot deployed to Preview – web-tools January 28, 2026 14:45 View deployment

Moustafa-Koterba added 2 commits January 28, 2026 17:04

feat(desktop): fix desktop typecheck

2219804

feat(desktop): setup mvvm for SendHeader component

80fdd1d

Moustafa-Koterba changed the title ~~Feature/live 20724~~ Feature/live 20724 [LLD][UI] Memo screen Jan 28, 2026

test(lld): update screenshots (ubuntu-22.04) lld, test, screenshot

e0c01b8

mcayuelas-ledger approved these changes Jan 29, 2026

View reviewed changes

dilaouid approved these changes Jan 29, 2026

View reviewed changes

Feature/live 20724 [LLD][UI] Memo screen #13505

Are you sure you want to change the base?

Feature/live 20724 [LLD][UI] Memo screen #13505

Uh oh!

Conversation

Moustafa-Koterba commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Checklist

📝 Description

What does this PR do ?

Context

What have changed

Screenshots

❓ Context

🧐 Checklist for the PR Reviewers

Uh oh!

vercel bot commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

live-github-bot bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Desktop Bundle Checks

Mobile Bundle Checks

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ E2E tests are required

🖥️ Desktop

📱 Mobile

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 28, 2026

Quality Gate failed

Uh oh!

mcayuelas-ledger commented Jan 29, 2026

Uh oh!

Moustafa-Koterba commented Jan 29, 2026

Uh oh!

Moustafa-Koterba commented Jan 29, 2026

Uh oh!

Moustafa-Koterba commented Jan 29, 2026 • edited by live-github-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Moustafa-Koterba commented Dec 31, 2025 •

edited

Loading

vercel bot commented Dec 31, 2025 •

edited

Loading

live-github-bot bot commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Jan 28, 2026 •

edited

Loading

Moustafa-Koterba commented Jan 29, 2026 •

edited by live-github-bot bot

Loading