Skip to content

Conversation

@dilaouid
Copy link
Member

@dilaouid dilaouid commented Jan 2, 2026

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • addAddress is not called in the Recipient step anymore but during the Broadcast

πŸ“ Description

Changes the placement of addAddress of the RecentAddressStore
Not called in Recipient step but when the tx is broadcasted successfully

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@dilaouid dilaouid requested a review from a team as a code owner January 2, 2026 10:49
@vercel
Copy link

vercel bot commented Jan 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Review Updated (UTC)
ledger-live-github-bot Ignored Ignored Jan 2, 2026 10:49am
native-ui-storybook Ignored Ignored Jan 2, 2026 10:49am
react-ui-storybook Ignored Ignored Jan 2, 2026 10:49am
web-tools Ignored Ignored Jan 2, 2026 10:49am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jan 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

πŸ–₯️ Desktop

-> Run Desktop E2E

  • Select "Run workflow"
  • Branch: feat/change-add-address-placement
  • Device: nanoSP or stax

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

@dilaouid dilaouid merged commit 1f3a08f into develop Jan 12, 2026
60 checks passed
@dilaouid dilaouid deleted the feat/change-add-address-placement branch January 12, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Has changes in LLD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants