Qaa 665 llm add typecheck #13523
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2441,15 +2441,15 @@ DEPENDENCIES: | |
| - BVLinearGradient (from `../node_modules/react-native-linear-gradient`) | ||
| - "DatadogSDKReactNative (from `../node_modules/@datadog/mobile-react-native`)" | ||
| - "DoubleConversion (from `../../../node_modules/.pnpm/[email protected]_patch_hash=2b53c1e5f1809d0b579eb158f0090709b837442527d3897d1f563069_e5c117d3d754a7a98c260b18dfeac954/node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`)" | ||
| - "EXConstants (from `../../../node_modules/.pnpm/[email protected].8_176ddfde7199fc8230440531d34b5a22/node_modules/expo-constants/ios`)" | ||
| - "EXImageLoader (from `../../../node_modules/.pnpm/[email protected].0_176ddfde7199fc8230440531d34b5a22/node_modules/expo-image-loader/ios`)" | ||
| - "Expo (from `../../../node_modules/.pnpm/[email protected].46_@[email protected]_@[email protected]_@[email protected]__expo-modul_53140f7fb2100cd288f142e41dfd26ed/node_modules/expo`)" | ||
| - "ExpoAsset (from `../../../node_modules/.pnpm/[email protected].5_fe27d0449b241e4d57297a8cc76e548f/node_modules/expo-asset/ios`)" | ||
| - "ExpoCrypto (from `../../../node_modules/.pnpm/[email protected].2_176ddfde7199fc8230440531d34b5a22/node_modules/expo-crypto/ios`)" | ||
| - "ExpoFileSystem (from `../../../node_modules/.pnpm/[email protected].1_176ddfde7199fc8230440531d34b5a22/node_modules/expo-file-system/ios`)" | ||
| - "ExpoFont (from `../../../node_modules/.pnpm/[email protected].4_fe27d0449b241e4d57297a8cc76e548f/node_modules/expo-font/ios`)" | ||
| - "ExpoImageManipulator (from `../../../node_modules/.pnpm/[email protected].6_176ddfde7199fc8230440531d34b5a22/node_modules/expo-image-manipulator/ios`)" | ||
| - "ExpoKeepAwake (from `../../../node_modules/.pnpm/[email protected].3_176ddfde7199fc8230440531d34b5a22/node_modules/expo-keep-awake/ios`)" | ||
| - "ExpoModulesCore (from `../../../node_modules/.pnpm/[email protected][email protected]_patch_hash=2b53c1e5f1809d0b579eb158f0090709_66be2728568375034107a6ab68203d84/node_modules/expo-modules-core`)" | ||
| - "fast_float (from `../../../node_modules/.pnpm/[email protected]_patch_hash=2b53c1e5f1809d0b579eb158f0090709b837442527d3897d1f563069_e5c117d3d754a7a98c260b18dfeac954/node_modules/react-native/third-party-podspecs/fast_float.podspec`)" | ||
| - "FBLazyVector (from `../../../node_modules/.pnpm/[email protected]_patch_hash=2b53c1e5f1809d0b579eb158f0090709b837442527d3897d1f563069_e5c117d3d754a7a98c260b18dfeac954/node_modules/react-native/Libraries/FBLazyVector`)" | ||
|
|
@@ -2613,23 +2613,23 @@ EXTERNAL SOURCES: | |
| DoubleConversion: | ||
| :podspec: "../../../node_modules/.pnpm/[email protected]_patch_hash=2b53c1e5f1809d0b579eb158f0090709b837442527d3897d1f563069_e5c117d3d754a7a98c260b18dfeac954/node_modules/react-native/third-party-podspecs/DoubleConversion.podspec" | ||
| EXConstants: | ||
| :path: "../../../node_modules/.pnpm/[email protected].8_176ddfde7199fc8230440531d34b5a22/node_modules/expo-constants/ios" | ||
| EXImageLoader: | ||
| :path: "../../../node_modules/.pnpm/[email protected].0_176ddfde7199fc8230440531d34b5a22/node_modules/expo-image-loader/ios" | ||
| Expo: | ||
| :path: "../../../node_modules/.pnpm/[email protected].46_@[email protected]_@[email protected]_@[email protected]__expo-modul_53140f7fb2100cd288f142e41dfd26ed/node_modules/expo" | ||
| ExpoAsset: | ||
| :path: "../../../node_modules/.pnpm/[email protected].5_fe27d0449b241e4d57297a8cc76e548f/node_modules/expo-asset/ios" | ||
| ExpoCrypto: | ||
| :path: "../../../node_modules/.pnpm/[email protected].2_176ddfde7199fc8230440531d34b5a22/node_modules/expo-crypto/ios" | ||
| ExpoFileSystem: | ||
| :path: "../../../node_modules/.pnpm/[email protected].1_176ddfde7199fc8230440531d34b5a22/node_modules/expo-file-system/ios" | ||
| ExpoFont: | ||
| :path: "../../../node_modules/.pnpm/[email protected].4_fe27d0449b241e4d57297a8cc76e548f/node_modules/expo-font/ios" | ||
| ExpoImageManipulator: | ||
| :path: "../../../node_modules/.pnpm/[email protected].6_176ddfde7199fc8230440531d34b5a22/node_modules/expo-image-manipulator/ios" | ||
| ExpoKeepAwake: | ||
| :path: "../../../node_modules/.pnpm/[email protected].3_176ddfde7199fc8230440531d34b5a22/node_modules/expo-keep-awake/ios" | ||
| ExpoModulesCore: | ||
| :path: "../../../node_modules/.pnpm/[email protected][email protected]_patch_hash=2b53c1e5f1809d0b579eb158f0090709_66be2728568375034107a6ab68203d84/node_modules/expo-modules-core" | ||
| fast_float: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| // Skip Husky install in production and CI | ||
| if (process.env.NODE_ENV === 'production' || process.env.CI === 'true') { | ||
| process.exit(0) | ||
| } | ||
| const husky = (await import('husky')).default | ||
| console.log(husky()) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # .husky/pre-push | ||
cunhabruno marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if git diff --name-only origin/main...HEAD | grep -q "^e2e/mobile"; then | ||
| echo "Running Husky pre-push for e2e mobile" | ||
| echo "You can skip this by setting HUSKY=0 env var or adding -n/--no-verify on git command" | ||
|
|
||
| pnpm e2e:mobile typecheck | ||
cunhabruno marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,43 +2,27 @@ | |||||||||||||
| "extends": "../../tsconfig.base.json", | ||||||||||||||
| "compilerOptions": { | ||||||||||||||
| "experimentalDecorators": true, | ||||||||||||||
| "moduleResolution": "bundler", | ||||||||||||||
cunhabruno marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||
| "moduleDetection": "force", | ||||||||||||||
| "module": "preserve", | ||||||||||||||
cunhabruno marked this conversation as resolved.
Show resolved
Hide resolved
Comment on lines
+5
to
+7
There was a problem hiding this comment. The combination of "moduleResolution": "bundler" with "module": "preserve" may not be optimal for a Node.js testing environment. The "bundler" module resolution is designed for bundlers like Webpack or Vite, not for Node.js. For a Node.js environment with modern TypeScript, consider using "moduleResolution": "node" or "nodenext" instead, along with an appropriate "module" setting like "commonjs" or "esnext".
Suggested change
Contributor
Author
There was a problem hiding this comment. I had to set it as bundler and preserve, because we are importing modules from apps/ledger-live-mobile, typecheck would fail otherwise. Any other suggestion? |
||||||||||||||
| "isolatedModules": true, | ||||||||||||||
| "allowJs": false, | ||||||||||||||
| "checkJs": false, | ||||||||||||||
| "jsx": "react-native", | ||||||||||||||
| "lib": ["es2017", "DOM"], | ||||||||||||||
| "skipLibCheck": true, | ||||||||||||||
| "noEmit": true, | ||||||||||||||
| "baseUrl": ".", | ||||||||||||||
| "typeRoots": ["./types", "./node_modules/@types"], | ||||||||||||||
| "paths": { | ||||||||||||||
| "LLM/*": ["../../apps/ledger-live-mobile/src/newArch/*"], | ||||||||||||||
| "~/*": ["../../apps/ledger-live-mobile/src/*"] | ||||||||||||||
| } | ||||||||||||||
| }, | ||||||||||||||
| "include": [ | ||||||||||||||
| "./**/*.ts", | ||||||||||||||
| "../../apps/ledger-live-mobile/**/*.d.ts", | ||||||||||||||
| "../../apps/ledger-live-mobile/src/**/*.{ts,tsx}" | ||||||||||||||
| ], | ||||||||||||||
| "exclude": ["node_modules", "babel.config.js", "jest.config.js"] | ||||||||||||||
| } | ||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.