Skip to content

Conversation

@LucasWerey
Copy link
Member

@LucasWerey LucasWerey commented Jan 5, 2026

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Bump reduxjs/toolkit to latest (^2.11.2)

Drop redux-actions and use reduxjs/toolkit (createAction is iso, handleAction has been adapted)

Reduxjs/toolkit bump brings a bump of immer. The new immer version uses ESM so we need to update jest config

  • client-ids:
    - redux moved to peer and devDep

  • common:
    - redux moved to peer and devDep

  • cryptoassets:
    - redux moved to peer and devDep

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel
Copy link

vercel bot commented Jan 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Review Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Jan 9, 2026 9:56am
native-ui-storybook Ignored Ignored Preview Jan 9, 2026 9:56am
react-ui-storybook Ignored Ignored Preview Jan 9, 2026 9:56am
web-tools Ignored Ignored Preview Jan 9, 2026 9:56am

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Jan 5, 2026
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 5, 2026

Mobile Bundle Checks

Comparing e54b435 against 5ed79db.

βœ… Previous issues have all been fixed.

Desktop Bundle Checks

Comparing e54b435 against 5ed79db.

βœ… Previous issues have all been fixed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
78.7% Coverage on New Code (required β‰₯ 80%)
50 New Code Smells (required ≀ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@LucasWerey LucasWerey closed this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants