Skip to content

Conversation

@cedelavergne-ledger
Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger commented Dec 30, 2025

Description

Add Linked List from app-ethereum to be usable by other apps

Tested using app-ethereum (test_gcs.py, test_eip712.py) after replacing all occurences.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Auto cherry-pick in API_LEVEL

If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:

[X] TARGET_API_LEVEL: API_LEVEL_25

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 97.67081% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.98%. Comparing base (f2b17ba) to head (de3b2e6).

Files with missing lines Patch % Lines
lib_c_list/c_list.c 94.11% 12 Missing ⚠️
unit-tests/lib_c_list/test_c_list.c 99.31% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1370      +/-   ##
==========================================
+ Coverage   79.98%   81.98%   +1.99%     
==========================================
  Files          43       45       +2     
  Lines        5067     5711     +644     
  Branches      745      817      +72     
==========================================
+ Hits         4053     4682     +629     
- Misses        926      938      +12     
- Partials       88       91       +3     
Flag Coverage Δ
unittests 81.98% <97.67%> (+1.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/lib_list branch 2 times, most recently from 33a1cf8 to ce11b74 Compare December 31, 2025 08:54
@cedelavergne-ledger cedelavergne-ledger marked this pull request as ready for review January 6, 2026 16:04
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/lib_list branch 3 times, most recently from 4adc08a to 6dde291 Compare January 21, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants