Add support for iAP2 over seph protocol#1421
Open
yrichard-ledger wants to merge 1 commit intomasterfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
=======================================
Coverage 91.82% 91.82%
=======================================
Files 37 37
Lines 4244 4244
Branches 521 521
=======================================
Hits 3897 3897
Misses 257 257
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrichard-ledger
force-pushed
the
iap2
branch
from
aacf14a to
207b10a
Compare
|
|
||
| void USB_LEDGER_IAP_init(void); | ||
|
|
||
| int USB_LEDGER_iap_rx_seph_evt(uint8_t *seph_buffer, |
Member
There was a problem hiding this comment.
Minor: harmonize function naming
USB_LEDGER_iap_rx_seph_evt -> USB_LEDGER_IAP_rx_seph_evt
|
|
||
| int USB_LEDGER_IAP_send_apdu(const uint8_t *apdu_buf, uint16_t apdu_buf_length) | ||
| { | ||
| uint32_t status = -1; |
Member
There was a problem hiding this comment.
This should be an int. Even better if the function could return int32_t instead !
| if (apdu_type == APDU_TYPE_NFC) { | ||
| return IO_APDU_MEDIA_NFC; | ||
| } | ||
| if (apdu_type == APDU_TYPE_IAP) { |
Member
There was a problem hiding this comment.
Shouldn't it be under ifdef ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for apdus over USB iap2
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it.
Additional comments
Please post additional comments in this section if you have them, otherwise delete it.
Auto cherry-pick in API_LEVEL
If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:
[ ] TARGET_API_LEVEL: API_LEVEL_25
This will only create the PR with cherry-picks, ready to be reviewed and merged.
Remember: