Skip to content

Conversation

@bboilot-ledger
Copy link

This PR adds support for BIP32 wildcard following what has been done on ledger-secure-sdk install_params.py script.

Copy link

@iartemov-ledger iartemov-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be OK:

  • UT run fine locally
  • I have not tested the full cycle with a Rust app installation and with artificially wrong parameters

@sonarqubecloud
Copy link

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (2356499) to head (476930b).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
ledgerwallet/params.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #98   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          21      21           
  Lines        1394    1454   +60     
======================================
- Misses       1394    1454   +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants