Skip to content

feat: make skunk tracing optional (off by default) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnicoulaud-ledger merged 1 commit into from
Apr 29, 2025
Merged

feat: make skunk tracing optional (off by default) #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions modules/db-skunk/src/main/scala/pillars/db/db.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ object DB extends ModuleSupport:

def load(context: ModuleSupport.Context, modules: Modules): Resource[IO, DB] =
import context.*
given Files[IO] = Files.forIO
given Tracer[IO] = context.observability.tracer
given Files[IO] = Files.forIO
for
_ <- Resource.eval(logger.info("Loading DB module"))
config <- Resource.eval(reader.read[DatabaseConfig]("db"))
poolRes <- createPool(config)
_ <- Resource.eval(logger.info("DB module loaded"))
_ <- Resource.eval(logger.info("Loading DB module"))
config <- Resource.eval(reader.read[DatabaseConfig]("db"))
given Tracer[IO] = if config.tracing then context.observability.tracer else Tracer.noop[IO]
poolRes <- createPool(config)
_ <- Resource.eval(logger.info("DB module loaded"))
yield DB(config, poolRes)
end for
end load
Expand Down Expand Up @@ -103,6 +103,7 @@ final case class DatabaseConfig(
debug: Boolean = false,
probe: ProbeConfig = ProbeConfig(),
logging: LoggingConfig = LoggingConfig(),
tracing: Boolean = false,
typerStrategy: Typer.Strategy = Typer.Strategy.BuiltinsOnly,
extraParameters: Map[String, String] = Map.empty,
commandCache: Int = 1024,
Expand Down