Skip to content

fix(template): typo of jinja2 minus and package name #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tai271828 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(template): typo of jinja2 minus and package name #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions {{cookiecutter.project_slug}}/docs/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ git checkout -b [YOUR FEATURE]

```sh
python -m pip install pipx
python -m pipx install {% if cookiecutter.dependency_management_tool == 'pipenv' -%}pipenv{%- elif cookiecutter.dependency_management_tool == 'poetry' -%}poetry{% endif -%} invoke
python -m pipx ensurepath
Copy link
Owner

@Lee-W Lee-W Jan 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean this line is not necessary? But in the documentation of pipx, it seems to be needed if you use it for the first time.

https://github.com/pipxproject/pipx

Copy link
Contributor Author

@tai271828 tai271828 Jan 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, it seems that I misunderstood something. Let me re-walk through the whole process to confirm its dependency. Thanks for the feedback!

Copy link
Contributor Author

@tai271828 tai271828 Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm I have no luck to install poetry with pipx.

ubuntu-mate 18.04 shows

$ pipx --version
0.16.0.0
$ pipx install poetry

No apps associated with package poetry or its dependencies. If you are attempting to install a library,
pipx should not be used. Consider using pip or a similar tool instead.

Would you mind showing me your output of pipx --version and pipx install poetry?

Copy link
Owner

@Lee-W Lee-W Feb 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... interesting

This how it looks like when I install it through pipx.

$ pipx --version
0.15.5.1
$ pipx install poetry
⚠️  Note: poetry was already on your PATH at ....../.pyenv/shims/poetry
  installed package poetry 1.1.4, Python 3.8.5
  These apps are now globally available
    - doesitcache
    - poetry
    - virtualenv
done! ✨ 🌟 ✨

It works even after I upgrade pipx to 0.16.0.0

Copy link
Owner

@Lee-W Lee-W May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tai271828 Is there any update on this one?

Copy link
Contributor Author

@tai271828 tai271828 May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, QQ. I did not work on this anymore. It's in my wish list of task. Feel free to close the pull request.

Copy link
Owner

@Lee-W Lee-W May 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries 🙂 Let's make it a draft one so that I know I don't need to review it at this moment.

Copy link
Contributor Author

@tai271828 tai271828 May 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Draft is a good idea so we could keep the track.

Yeah I have had dug into this issue and found it is a rabbit hole : (

python -m pipx install {% if cookiecutter.dependency_management_tool == 'pipenv' -%}pipenv{%- elif cookiecutter.dependency_management_tool == 'poetry' -%}poetry{%- endif %} invoke
```

* [pipx](https://github.com/pipxproject/pipx): for python tool management
Expand Down