-
Notifications
You must be signed in to change notification settings - Fork 402
Remove the external theme that we use, replaces with own one #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
Works now, but I plan to go page by page tomorrow to check whether e.g. chess game snippets still work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the external “whisper” theme with a custom “leela” theme by removing legacy layout, SCSS, and JS files, introducing streamlined Hugo templates under layouts/blog, and updating front matter with manual summaries.
- Removed all old theme layout, SCSS, and JS files.
- Added new
layouts/blog/section.htmlandlayouts/blog/page.html. - Updated
config.tomlto switch to the newleelatheme and addedsummaryfront matter entries.
Reviewed Changes
Copilot reviewed 243 out of 243 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| layouts/blog/single.html | Deleted – legacy single post template removed. |
| layouts/blog/section.html | Added – provides new blog index layout. |
| layouts/blog/page.html | Added – provides new single post layout. |
| layouts/blog/baseof.html | Deleted – legacy blog base template removed. |
| layouts/_default/baseof.html | Deleted – legacy default base template removed. |
| config.toml | Updated – theme changed to leela, removed old props. |
| content/play/configuration/**/*.md | Added summary front matter to key content files. |
| assets/scss/** | Deleted – removed legacy SCSS components. |
| assets/js/scripts.js | Deleted – removed legacy JS. |
Comments suppressed due to low confidence (3)
layouts/blog/section.html:3
- [nitpick] The CSS class here is
title, but inpage.htmlyou useblog-title. For consistent styling and maintainability, unify these class names (e.g. bothblog-titleor bothtitle).
<h1 class="title">{{ .Title }}</h1>
layouts/blog/section.html:1
- There’s no
baseof.htmlinlayouts/blog/or fallback in_default/. Without a base template to wrap these blocks, Hugo won’t render the layouts correctly. Please ensure you add a newbaseof.htmlor reference an existing one.
{{ define "body_classes" }}blog-index{{ end }}
layouts/blog/page.html:8
- [nitpick] The draft-banner markup is duplicated between
page.htmlandsection.html. Consider extracting it into a partial (e.g.partials/draft-banner.html) to reduce duplication and simplify future updates.
{{if .Draft}}
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
borg323
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly OK, and we can fix any small issues separately.
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
|
🚀 Draft Preview: http://pr130.drafts.lczero.org/ |
Uh oh!
There was an error while loading. Please reload this page.