Skip to content

Make ComparisonPair::try_new return an Option #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make ComparisonPair::try_new return an Option #3

wants to merge 1 commit into from

Conversation

nnethercote
Copy link

This is more idiomatic Rust, and doesn't allow the creation of invalid ComparisonPairs.

@nnethercote
Make ComparisonPair::try_new return an Option
a8e1702 
This is more idiomatic Rust, and doesn't allow the creation of invalid
`ComparisonPair`s.
@nnethercote
Copy link
Author

I filed this PR because try_new was highlighted as an example of a smart constructor that prevents invalid states in https://rust-gpu.github.io/blog/2025/07/25/rust-on-every-gpu.

@LegNeato
Copy link
Owner

LegNeato commented Aug 8, 2025

Yeah, I think I hit a codegen bug and it wasn't working, let's see how CI goes!

@nnethercote
Copy link
Author

Something odd is going on, for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnethercote @LegNeato