Light: Invert set_color_temperature range check#126
Open
forderud wants to merge 1 commit intoLeggin:mainfrom
Open
Light: Invert set_color_temperature range check#126forderud wants to merge 1 commit intoLeggin:mainfrom
forderud wants to merge 1 commit intoLeggin:mainfrom
Conversation
Fixes Leggin#125 by changing the logic, so that it fails if the temperature is _outside_ the valid range instead of _inside_.
Owner
|
Wow crazy this didn't come up earlier, thank you! |
Owner
|
No wait a minute, at least my lamps all have as min 4000 and as max 2022 |
Author
This was very odd. I've so far only purchased an Ikea KAJPLATS E27 WS G60 lamp that reports Could it be an idea to add logic for swapping min/max values to ensure that max is always greater than min? I'm thinking something along these lines... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125 by changing the logic, so that it fails if the temperature is outside the valid range instead of inside.