Removing all binds from codebase
#3780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested review from
Nutomic,
SleeplessOne1917 and
matc-pub
as code owners
Nutomic
approved these changes
Jan 20, 2026
Member
Nutomic
left a comment
Nutomic
left a comment
There was a problem hiding this comment.
Works fine in my quick testing. I believe the lint jsx-no-bind covers this, so you can use that.
Member
Author
|
That lint looks like its for something else (not allowing binds in jsx), but I prefer never allowing binds even in regular code. I'll merge as this is a big refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See below issue for context
binds and internal class method event handlers #3578This was a larger refactor done over the weekend, but I've removed all but a few
.binds from the codebase, and also fixed a lot of previously hidden bugs in the process.The diffs aren't clean because all the handler functions were moved to the bottom, but very little logical changes were necessary.
I tested and everything seems to work fine.