Fix for Peertube federation #6217
Draft
+191
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
commented
Dec 5, 2025
| } | ||
| } | ||
| Err(UntranslatedError::InvalidAttributedTo.into()) | ||
| } |
Member
Author
There was a problem hiding this comment.
Main change is here. As Peertube doesnt provide the type of items in attributed_to anymore, we now need to deref each one to find which is a Person. This makes it necessary to change the method to async and change the return type, which results in the other changes in this PR.
Member
Author
|
The Peertube developer says he wants to change their federation implementation to be compatible with Lemmy, then we could remove all the special logic for Peertube. Keeping this open until it is confirmed implemented on their side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by Chocobozzz/PeerTube#2704