Skip to content

Conversation

@sinhpham
Copy link
Contributor

@sinhpham sinhpham commented Aug 8, 2025

This PR adds support for tvOS to the package. Since the implementation for tvOS is identical to that of macOS and iOS, no code changes are needed.

@LeoBorai LeoBorai requested a review from Copilot August 9, 2025 10:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for tvOS to the package by including it in the existing Unix-like platform configurations. Since tvOS shares the same underlying implementation as macOS and iOS, the changes are minimal and consist only of adding the target_os = "tvos" condition to existing platform-specific configurations.

  • Added tvOS target configuration to conditional compilation attributes across multiple modules
  • Included tvOS in the build script's target OS handling
  • Updated Cargo.toml dependencies to include tvOS alongside other Unix-like platforms

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/utils/mod.rs Added tvOS to conditional compilation attributes for platform-specific modules
src/target/unix/ffi/mod.rs Included tvOS in Unix FFI target configuration
src/target/mod.rs Added tvOS to Unix module conditional compilation
build.rs Added tvOS constant and included it in target OS array
Cargo.toml Updated dependency configuration to include tvOS

Copy link
Owner

@LeoBorai LeoBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much @sinhpham!

@LeoBorai LeoBorai merged commit 35faf66 into LeoBorai:main Aug 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants