Skip to content

Conversation

@snltd
Copy link
Contributor

@snltd snltd commented Dec 16, 2025

Allows the crate to build on illumos. It's just another Unix target, so I didn't need to make any changes to the code.

Tests pass. Checked with rust 1.92.0.

@LeoBorai
Copy link
Owner

Hi @snltd, thanks for your PR!

I think its okay to merge it given that it doesn't change any behavior in terms of logic.

But I think it would also be great to have integrity checks on it, its there any recommended approach on testing in GH Actions? Perhaps we can add CI in a separate PR?

@LeoBorai LeoBorai merged commit acd1710 into LeoBorai:main Dec 17, 2025
12 checks passed
@snltd
Copy link
Contributor Author

snltd commented Dec 19, 2025

I have some stuff buildig in OmniOS from GHA, but it's a little heavyweight. e.g. https://github.com/snltd/gurp/actions/workflows/release.yml. I'd be happy to put together a similar action if you wish.

@LeoBorai
Copy link
Owner

I have some stuff buildig in OmniOS from GHA, but it's a little heavyweight. e.g. https://github.com/snltd/gurp/actions/workflows/release.yml. I'd be happy to put together a similar action if you wish.

Hi @snltd, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants