Skip to content

fix: add reporter prefix to module name constants#560

Merged
brunobls merged 3 commits intodevelopfrom
fix/module-name-prefix
Mar 6, 2026
Merged

fix: add reporter prefix to module name constants#560
brunobls merged 3 commits intodevelopfrom
fix/module-name-prefix

Conversation

@brunobls
Copy link
Member

@brunobls brunobls commented Mar 6, 2026

Pull Request Checklist

Pull Request Type

  • Manager
  • Worker
  • Frontend
  • Infrastructure
  • Packages
  • Pipeline
  • Tests
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

brunobls and others added 2 commits March 6, 2026 11:11
Add `reporter-` prefix to ModuleManager and ModuleWorker constants
to avoid naming collisions in multi-tenant context across services.
Also add API requests.http file for manager component testing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@brunobls brunobls requested a review from a team as a code owner March 6, 2026 14:15
@lerian-studio
Copy link
Contributor

Consider updating CHANGELOG.md to document this change. If this change doesn't need a changelog entry, add the skip-changelog label.

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7a14c798-950d-4fbd-a78d-9c269d536637

📥 Commits

Reviewing files that changed from the base of the PR and between 9a10a9c and 7f3de15.

📒 Files selected for processing (3)
  • components/manager/Makefile
  • components/worker/Makefile
  • pkg/constant/app.go

Walkthrough

This pull request updates module naming constants and applies minor whitespace formatting to Makefiles. The constants ModuleManager and ModuleWorker in pkg/constant/app.go are updated from "manager" and "worker" to "reporter-manager" and "reporter-worker" respectively. Trailing whitespace is added to comment lines in both components/manager/Makefile and components/worker/Makefile.


Comment @coderabbitai help to get the list of available commands and usage tips.

@brunobls brunobls merged commit cc62f60 into develop Mar 6, 2026
3 checks passed
@brunobls brunobls deleted the fix/module-name-prefix branch March 6, 2026 14:16
@lerian-studio
Copy link
Contributor

Consider updating CHANGELOG.md to document this change. If this change doesn't need a changelog entry, add the skip-changelog label.

@lerian-studio
Copy link
Contributor

This PR is very large (3 files, lines changed). Consider breaking it into smaller PRs for easier review.

@lerian-studio
Copy link
Contributor

📊 Unit Test Coverage Report: reporter-worker

Metric Value
Overall Coverage 90.9% ✅ PASS
Threshold 85%

Coverage by Package

Package Coverage
github.com/LerianStudio/reporter/components/worker/internal/services 93.0%

Generated by Go PR Analysis workflow

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

🔒 Security Scan Results — manager

Filesystem Scan

✅ No vulnerabilities or secrets found.

Docker Image Scan

✅ No vulnerabilities found.

All security checks passed.

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

🔒 Security Scan Results — worker

Filesystem Scan

✅ No vulnerabilities or secrets found.

Docker Image Scan

✅ No vulnerabilities found.

All security checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants