Skip to content

Comments

fix #267: addressed ESlint issues for JourneyCard component#656

Merged
jefische merged 3 commits intodevelopfrom
jeremy/267-ESlint-error-JourneyCard
Oct 30, 2025
Merged

fix #267: addressed ESlint issues for JourneyCard component#656
jefische merged 3 commits intodevelopfrom
jeremy/267-ESlint-error-JourneyCard

Conversation

@jefische
Copy link
Contributor

@jefische jefische commented Oct 27, 2025

Description

Before:

Linter produced these errors:

  • Line 1:1
    • Error: missing header header/header
  • Line 15:28
    • Error: Missing JSDoc comment. jsdoc/require-jsdoc
  • Line 18:22
    • Error: Missing return type on function. @typescript-eslint/explicit-function-return-type
  • Line 58:23
    • Error: Do not use Array index in keys react/no-array-index-key

After:

All linting errors resolved:

  • Added header
  • Added JSDoc for JourneyCard
  • Added explicit JSX.Element return type for JourneyCard
  • Added id property to journeySteps array for use with key prop during list rendering

Closes #267

Screenshot

image

Pre-submission checklist

  • Code builds and passes locally
  • PR title follows Conventional Commit format (e.g. test #001: created unit test for __ component)
  • Request reviews from the Peer Code Reviewers and Senior+ Code Reviewers groups
  • Thread has been created in Discord and PR is linked in gis-code-questions

@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
elecretanta Ready Ready Preview Comment Oct 30, 2025 2:04am
elecretanta-storybook Ready Ready Preview Comment Oct 30, 2025 2:04am
elecretanta-unit-test Ready Ready Preview Comment Oct 30, 2025 2:04am

@shashilo shashilo requested review from a team, bethanyann and tonyb650 and removed request for a team, HoldUpFjord, alexappleget, bethanyann, jennifertieu, kepsteen, nickytonline and shashilo October 27, 2025 15:47
Copy link
Contributor

@tonyb650 tonyb650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@bethanyann bethanyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jefische jefische deleted the jeremy/267-ESlint-error-JourneyCard branch October 30, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address ESlint errors in the file: ./components/JourneyCard/JourneyCard.tsx

3 participants