feat #655: implements an error handling system with custom errors#657
Merged
feat #655: implements an error handling system with custom errors#657
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…anta into hector/655-update-nextjs-error-responses
…anta into hector/655-update-nextjs-error-responses
…ecessary lines in the log
…justs log for unknown errors
shashilo
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before:
Backend routes/functions were thrown or returned without always being caught.
After:
lib/errors/CustomErrors.ts.BackendError,OpenAiError,SupabaseError,GoogleErrorroute.ts.generateAndStoreSuggestions()function throws anOpenAiError, which gets rethrown indrawGiftExchange(), rethrown again inprocessGiftExchanges(), then finally caught and logged in aroute.ts.success: boolean. I removed these returns, but errors will still be thrown.logError(error: unknown)function located inlib/errors/logError.ts. This function is accepts the error to correctly identify and log it, as well as being easily expandable to new error types if they get created.Closes #655
Screenshots
Example of error log in the terminal
Pre-submission checklist
test #001: created unit test for __ component)Peer Code ReviewersandSenior+ Code Reviewersgroupsgis-code-questions